Bug 242825

Summary: devel/spdlog: fix build on GCC architectures
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: Vanilla I. Shu <vanilla>
Status: Closed FIXED    
Severity: Affects Only Me CC: vanilla
Priority: --- Flags: vanilla: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch pkubaj: maintainer-approval? (vanilla)

Description Piotr Kubaj freebsd_committer freebsd_triage 2019-12-23 05:11:41 UTC
Created attachment 210169 [details]
patch

assert() is not declared by default:
In file included from /wrkdirs/usr/ports/devel/spdlog/work/spdlog-1.4.2/src/async.cpp:11:
/wrkdirs/usr/ports/devel/spdlog/work/spdlog-1.4.2/include/spdlog/details/thread_pool-inl.h: In member function 'bool spdlog::details::thread_pool::process_next_msg_()':
/wrkdirs/usr/ports/devel/spdlog/work/spdlog-1.4.2/include/spdlog/details/thread_pool-inl.h:119:9: error: 'assert' was not declared in this scope
  119 |         assert(false && "Unexpected async_msg_type");
      |         ^~~~~~
Comment 1 Vanilla I. Shu freebsd_committer freebsd_triage 2019-12-23 05:22:00 UTC
Approved, please help to commit, thanks.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-12-23 14:10:25 UTC
A commit references this bug:

Author: pkubaj
Date: Mon Dec 23 14:09:48 UTC 2019
New revision: 520723
URL: https://svnweb.freebsd.org/changeset/ports/520723

Log:
  devel/spdlog: fix build on GCC architectures

  assert() is not declared by default:
  In file included from /wrkdirs/usr/ports/devel/spdlog/work/spdlog-1.4.2/src/async.cpp:11:
  /wrkdirs/usr/ports/devel/spdlog/work/spdlog-1.4.2/include/spdlog/details/thread_pool-inl.h: In member function 'bool spdlog::details::thread_pool::process_next_msg_()':
  /wrkdirs/usr/ports/devel/spdlog/work/spdlog-1.4.2/include/spdlog/details/thread_pool-inl.h:119:9: error: 'assert' was not declared in this scope
    119 |         assert(false && "Unexpected async_msg_type");
        |         ^~~~~~

  PR:		242825
  Approved by:	vanilla (maintainer)

Changes:
  head/devel/spdlog/files/
  head/devel/spdlog/files/patch-include_spdlog_details_pattern__formatter-inl.h
  head/devel/spdlog/files/patch-include_spdlog_details_thread__pool-inl.h