Bug 242826

Summary: www/newsboat 2.18 build fails by depending on old LibreSSL 2.5 through 2.9.x
Product: Ports & Packages Reporter: p5B2EA84B3
Component: Individual Port(s)Assignee: Tobias Kortkamp <tobik>
Status: Closed FIXED    
Severity: Affects Only Me CC: mt-bugs, w.schwarzenfeld
Priority: --- Keywords: needs-patch
Version: LatestFlags: bugzilla: maintainer-feedback? (mt-bugs)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
svn-diff-newsboat-libressl
none
bump openssl crate version none

Description p5B2EA84B3 2019-12-23 09:36:01 UTC 
Demanding an outdated version of LibreSSL is unsafe.

cargo:conf=OPENSSL_NO_BUF_FREELISTS,OPENSSL_NO_COMP,OPENSSL_NO_KRB5,OPENSSL_NO_PSK,OPENSSL_NO_RFC3779,OPENSSL_NO_SRP,OPENSSL_NO_SSL3_METHOD
cargo:rustc-cfg=libressl
cargo:rustc-cfg=libressl251
cargo:rustc-cfg=libressl261
cargo:rustc-cfg=libressl270
cargo:rustc-cfg=libressl271
cargo:rustc-cfg=libressl273
cargo:rustc-cfg=libressl280
cargo:rustc-cfg=libressl281
cargo:rustc-cfg=libressl291
cargo:libressl_version_number=3000200f

--- stderr
thread 'main' panicked at '

This crate is only compatible with OpenSSL 1.0.1 through 1.1.1, or LibreSSL 2.5
through 2.9.x, but a different version of OpenSSL was found. The build is now aborting
due to this version mismatch.
Comment 1 Walter Schwarzenfeld 2019-12-23 11:30:01 UTC 
It's a rust problem. Found similar in bug #241411. CC'd rust.
Comment 2 Walter Schwarzenfeld 2019-12-23 11:39:01 UTC 
(In reply to Walter Schwarzenfeld from comment #1)
Sorry, seems I was wrong.
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2019-12-23 12:07:20 UTC 
Not a Rust problem per se.  Individual ports are responsible for themselves
to patch vendored dependencies if necessary.

In newsboat the openssl-sys crate is fairly old and should probably be bumped
to the newest version or LibreSSL 3.x support should be patched in like we
did in ports r516995 for lang/rust.  Either way it's up to the reporter
or other people interested in LibreSSL to test and provide an appropriate
patch.
Comment 4 Walter Schwarzenfeld 2019-12-23 12:49:52 UTC 
Created attachment 210174 [details]
svn-diff-newsboat-libressl

Ok, here it is.
Comment 5 Marko Turk 2019-12-26 18:38:03 UTC 
(In reply to Walter Schwarzenfeld from comment #4)
Why not do the same that was done in newsboat upstream?

https://github.com/newsboat/newsboat/pull/706/commits/d9f143bf5d4cf87effae2532b9f2ef0c2be0139d

It was commited after 2.18 relase and it will be in the next release. But until then, maybe it's better to add this patch to our port?

BR/Marko
Comment 6 Walter Schwarzenfeld 2019-12-26 20:39:12 UTC 
(In reply to Marko Turk from comment #5)
I did not found that.
Comment 7 Marko Turk 2020-01-04 21:06:19 UTC 
Created attachment 210454 [details]
bump openssl crate version
Comment 8 Marko Turk 2020-01-04 21:06:48 UTC 
Hi Walter,

can you try if this new patch works for you?

Thanks.

BR,
Marko
Comment 9 Walter Schwarzenfeld 2020-01-04 23:21:57 UTC 
Yes, seems to work. Thanks!
Comment 10 commit-hook freebsd_committer freebsd_triage 2020-01-05 05:59:59 UTC 
A commit references this bug:

Author: tobik
Date: Sun Jan  5 05:59:11 UTC 2020
New revision: 522111
URL: https://svnweb.freebsd.org/changeset/ports/522111

Log:
  www/newsboat: Bump openssl-sys crate to fix build with LibreSSL 3.x

  libc bump is not really needed but mirrors
  https://github.com/newsboat/newsboat/commit/d9f143bf5d4cf87effae2532b9f2ef0c2be0139d

  PR:		242826
  Reported by:	p5B2E9A8F@t-online.de
  Submitted by:	mt@markoturk.info (maintainer)
  Tested by:	w.schwarzenfeld@utanet.at

Changes:
  head/www/newsboat/Makefile
  head/www/newsboat/distinfo
Comment 11 commit-hook freebsd_committer freebsd_triage 2020-01-05 06:01:00 UTC 
A commit references this bug:

Author: tobik
Date: Sun Jan  5 06:00:06 UTC 2020
New revision: 522112
URL: https://svnweb.freebsd.org/changeset/ports/522112

Log:
  MFH: r522111

  www/newsboat: Bump openssl-sys crate to fix build with LibreSSL 3.x

  libc bump is not really needed but mirrors
  https://github.com/newsboat/newsboat/commit/d9f143bf5d4cf87effae2532b9f2ef0c2be0139d

  PR:		242826
  Reported by:	p5B2E9A8F@t-online.de
  Submitted by:	mt@markoturk.info (maintainer)
  Tested by:	w.schwarzenfeld@utanet.at

  Approved by:	ports-secteam build fix blanket

Changes:
_U  branches/2020Q1/
  branches/2020Q1/www/newsboat/Makefile
  branches/2020Q1/www/newsboat/distinfo