Bug 242892

Summary: graphics/waffle: update to 1.6.0, build with meson, add xdg-shell support
Product: Ports & Packages Reporter: Val Packett <val>
Component: Individual Port(s)Assignee: Tobias Kortkamp <tobik>
Status: Closed FIXED    
Severity: Affects Only Me Flags: tobik: maintainer-feedback-
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on: 242893    
Bug Blocks: 242792    
Attachments:
Description Flags
waffle.patch none

Description Val Packett 2019-12-26 13:42:46 UTC 
Created attachment 210233 [details]
waffle.patch

- Waffle moved to freedesktop gitlab
- Now supports building with Meson, which allows us to remove all the CMake patches from the port
- New version generates CMake config with 'Waffle' named variables (which devel/apitrace expects) instead of 'WAFFLE'
- (git rev instead of just 1.6.0 is used because CMake config generation was added to Meson build)
- Extra xdg-shell patch https://gitlab.freedesktop.org/mesa/waffle/merge_requests/60 to make devel/apitrace 'eglretrace' work on modern Wayland compositors (wlroots has removed the old wl-shell protocol, so this is required to make apitrace's debug trace replays work on sway/wayfire/…)
- All backends are now options (on by default)
- Manpages are now built
- The only in-tree consumer for now (piglit) builds fine, at least with a small patch that adds a missing EGL_NO_CONFIG_MESA define. IDK if that's related to Waffle, it's probably actually because I have the current dev version of mesa. I'll post that piglit patch separately.
Comment 1 Val Packett 2019-12-26 13:58:51 UTC 
(piglit is Bug 242893, apitrace is Bug 242792)
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-01-23 12:43:19 UTC 
A commit references this bug:

Author: tobik
Date: Thu Jan 23 12:42:56 UTC 2020
New revision: 523925
URL: https://svnweb.freebsd.org/changeset/ports/523925

Log:
  graphics/waffle: Update to 1.6.0-7

  - Waffle moved to freedesktop gitlab
  - Now supports building with Meson, which allows us to remove all
    the CMake patches from the port.  The Meson build however still
    expects that cmake is available in the build environment.
  - New version generates CMake config with 'Waffle' named variables
    (which devel/apitrace expects) instead of 'WAFFLE'
  - Extra xdg-shell patch to make devel/apitrace 'eglretrace' work
    on modern Wayland compositors (wlroots has removed the old wl-shell
    protocol, so this is required to make apitrace's debug trace
    replays work on sway/wayfire/...)
  - All backends are now options (on by default)
  - Manpages are now built
  - graphics/piglit needs a small patch to build

  PR:		242892, 242893
  Submitted by:	Greg V <greg@unrelenting.technology> (based on)
  Approved by:	x11 (maintainer timeout, 27 days)

Changes:
  head/graphics/piglit/files/patch-tests_egl_egl-context-priority.c
  head/graphics/waffle/Makefile
  head/graphics/waffle/distinfo
  head/graphics/waffle/files/
  head/graphics/waffle/pkg-plist