Bug 242943
| Summary: | graphics/darktable: upgrade to 3.0.0 release [non-maintainer submission] | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Matthias Andree <mandree> | ||||
| Component: | Individual Port(s) | Assignee: | Jean-Sébastien Pédron <dumbbell> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Many People | CC: | mandree | ||||
| Priority: | --- | Flags: | dumbbell:
maintainer-feedback+
|
||||
| Version: | Latest | ||||||
| Hardware: | amd64 | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
The patch looks good to me, thank you! Feel free to commit it. One quick question: what is the purpose of "-Wl,--as-needed"? The -Wl,--as-needed was an unsuccessful attempt at fixing the extra libintl.so inclusion. Doesn't seem to make a difference on 12.1. I will commit without it to avoid confusion. A commit references this bug: Author: mandree Date: Mon Jan 6 16:52:01 UTC 2020 New revision: 522259 URL: https://svnweb.freebsd.org/changeset/ports/522259 Log: graphics/darktable: update to new release 3.0.0 Announcement: <https://www.darktable.org/2019/12/darktable-300-released/> <https://www.darktable.org/2019/12/darktable-30/> Additional changes: - ONLY_FOR_ARCHS* variables moved up to please portlint - some CMAKE_ARGS hacks with CMAKE_*_COMPILER_LAUNCHER to get ccache back in - switch from hardcoding LLVM_VER=60 to ${LLVM_DEFAULT} - strip out -D_XOPEN_SOURCE=... (upstream CMakeLists.txt) because it is harmful in hiding, for instance, u_char typedefs, which causes compilation failure down the road for cups_print. PR: 242943 Approved by: dumbbell@ (maintainer) Changes: head/graphics/darktable/Makefile head/graphics/darktable/distinfo head/graphics/darktable/pkg-plist Thanks for the review and approval, committed to ports/ head. |
Created attachment 210288 [details] update darktable from 2.6.2_3 to 3.0.0 (new upstream release) Greetings, find attached an upgrade to darktable 3.0.0 - let's see if we can get this in before 2020Q1 branches! Additional changes: - ONLY_FOR_ARCHS* variables moved up to please portlint - LDFLAGS add -Wl,--as-needed (not sure if that fixes libintl for non-NLS configurations) - some CMAKE_ARGS hacks with CMAKE_*_COMPILER_LAUNCHER to get ccache back in - switch from hardcoding LLVM_VER=60 to ${LLVM_DEFAULT} - strip out -D_XOPEN_SOURCE=... (upstream CMakeLists.txt) because it is harmful in hiding, for instance, u_char typedefs, which causes compilation failure down the road for cups_print. Compile tested on 12.0 amd64 (poudriere) and 12.1 amd64 (live system), and lightly smoke tested (12.1 live) meaning that import, lighttable, darkroom work on one Sony .ARW image.