Bug 243057

Summary: wrong mbuf passed to key_sendup_mbuf by key_spdacquire
Product: Base System Reporter: Masse Nicolas <nicolas.masse>
Component: kernAssignee: freebsd-bugs (Nobody) <bugs>
Status: New ---    
Severity: Affects Only Me CC: ae, markj
Priority: --- Keywords: patch
Version: 11.2-RELEASE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Pass result to key_sendup_mbuf instead of m none

Description Masse Nicolas 2020-01-03 13:39:54 UTC
Created attachment 210416 [details]
Pass result to key_sendup_mbuf instead of m

The method key_spdacquire pass the parameter "m" to key_sendup_mbuf, or this parameter is always NULL (due to the for loop above).
It should pass the mbuf "result instead"
Comment 1 Andrey V. Elsukov freebsd_committer freebsd_triage 2020-01-04 10:48:28 UTC
I think the patch is correct. However this part of code is unused, this is why it has never triggered the assertion. SPDACQUIRE message was not implemented and it is not hooked to the key_typesw.
Comment 2 Mark Johnston freebsd_committer freebsd_triage 2020-01-16 17:50:51 UTC
(In reply to Masse Nicolas from comment #0)
How did you notice the problem?