Bug 243109
| Summary: | [PATCH] editors/vim: Allow parallel build | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Greg Lewis <glewis> | ||||
| Component: | Individual Port(s) | Assignee: | Adam Weinberger <adamw> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(adamw) |
||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Hi Greg, I'm torn on this. Personally, I have `.undef MAKE_JOBS_UNSAFE` in Makefile.local on my boxes. But every time I've done this, I've gotten reports of failures and had to put it back in. The unfortunate truth is that the dependency chain in the Makefile is a complete nightmare and upstream has a very bad track record of getting the deps right. I'm not opposed to removing it, but I'd say that the probability of needing to put it back in is close to 1. What about an OPTION (defaulting to off) to enable parallel build? Would that be a reasonable compromise? Thanks Adam. I definitely trust your experience as maintainer here and agree you shouldn't commit this as is. Likely this affects a relatively small number of people since I expect most FreeBSD users now use binary packages and are not concerned about the build time. Given that, I think having it as an option is a reasonable solution for those of us who do build from source. I'm also happy to keep this as a local change if you don't want to go to the trouble of an option (although the option may prevent similar PRs in future). A commit references this bug: Author: adamw Date: Mon Jan 6 00:19:42 UTC 2020 New revision: 522175 URL: https://svnweb.freebsd.org/changeset/ports/522175 Log: vim: Add a MAKE_JOBS option for concurrent build, default off Most systems are able to build vim in parallel most of the time. The dependency chain in the Makefiles are a spaghetti mess and concurrency is broken with some frequency, so it just isn't feasible for it to be on by default. It does shave quite a bit of time off the build (and I have had .undef MAKE_JOBS_UNSAFE in Makefile.local for years), so now there's an option. It's off by default. PR: 243109 Reported by: glewis Changes: head/editors/vim/Makefile Thanks for the prompt on this, Greg. This option should have been in the Makefile years ago. Hearing that I wasn't the only one was very helpful here! |
Created attachment 210462 [details] Enable parallel building The attached patch removes MAKE_JOBS_UNSAFE for vim. I haven't tried all the combinations of options, but this works for me with a relatively large set of options turned on and makes the build considerably faster.