Bug 243158
| Summary: | x11/libICE: add DOCS option | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Andrew Romanenko <melanhit> | ||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-x11 (Nobody) <x11> | ||||||||
| Status: | Closed Not Accepted | ||||||||||
| Severity: | Affects Only Me | CC: | zeising | ||||||||
| Priority: | --- | Keywords: | buildisok | ||||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(x11) |
||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
I see little reason for this, considering it's only 2 files that are affected. However, they should be installed by default (the DOCS option should be enabled), this way the package isn't changed. Created attachment 210501 [details]
libICE_v0.patch
ok
The patch isn't complete, %%PORTDOCS%%%%DOCSDIR%%/ice.xml is still installed into the stage dir even when DOCS is off. You don't need to set DOCS in OPTIONS_DEFAULT, it's added automatically by the framework. Created attachment 210510 [details]
libICE_v1.patch
OPTIONS_DEFAULT removed, %%PORTDOCS%%%%DOCSDIR%%/ice.xml is not installed if DOCS is off (build via poudriere 12.1/STABLE amd64).
thanks for DOCS is on by default via framework.
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/111247407 This is very little benefit for a lot of complexity. It is just two files in the package, text files that compresses quite well, but it means that on every update or test I need to test both the case with or without the DOCS option, doubling the number of tests needed. |
Created attachment 210500 [details] libICE.patch Add option for DOCS (disabled by default)