Bug 243291
| Summary: | www/squid PCRE regexp doesn't work anymore | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | OlivierW <olivierw1+bugzilla-freebsd> | ||||||
| Component: | Individual Port(s) | Assignee: | Yasuhiro Kimura <yasu> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | timp87, yasu | ||||||
| Priority: | --- | Keywords: | needs-qa | ||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(timp87) koobs: merge-quarterly? |
||||||
| Hardware: | amd64 | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
|
Description
OlivierW
2020-01-12 10:11:01 UTC
(In reply to OlivierW from comment #0) Hello, thanks a lot for the report! And sorry for the delay. I'm gonna update squid to 4.10 and try to fix it. Well, to get right answers about --enable-gnuregex it's better to ask squid maillist instead and rise an discussion there. I'm trying to understand how it may be fixed the right way. (In reply to OlivierW from comment #0) Could you share your example of ACL to check it? Hello, Thanks for your answer! I currently don't have access to the specific regexes, but they are similar to: acl example url_regex -i ^http:\/\/www\.example\.com\/.*?\.js I've tried this one in a VM with FreeBSD 12.1 and Squid 4.10 from ports and I am getting the error. I've found I can fix it by removing the lazy quantifier (from .*? to .*): acl example url_regex -i ^http:\/\/www\.example\.com\/.*\.js Both regexes are accepted with Squid 4.10 compiled with "--enable-gnuregex". Maybe I should just change my regexes to remove the lazy quantifier? Hoping it's the only case causing a problem. As you said, I'll ask on Squid's mailing list to know what is the right thing to do. Best Regards, Olivier (In reply to OlivierW from comment #3) Have you got any answer from squid maillist? Hello, Sorry it took me over a year to ask on Squid's mailing-list :-/ I have just posted a message here: http://lists.squid-cache.org/pipermail/squid-users/2021-June/023765.html I'll report back when I have answers. PS: since my first message here, I am now using Squid 4.14 on FreeBSD 13.0 and I still have to compile with the "--enable-gnuregex" option. Best Regards, Olivier Hello, I got an answer from Amos: http://lists.squid-cache.org/pipermail/squid-users/2021-June/023766.html So, GNU regex library is deprecated and will be replaced by std::regex C++ later. Well, for now I'll just fix and/or remove my problematic rules so I won't need PCRE anymore. And as I was probably the only one using this on FreeBSD, I think I should revert my patch from 2017: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223505 and completely remove the "PCRE" option of the port. What do you think? Best Regards, Olivier (In reply to OlivierW from comment #6) Thank you! I think we'll remove this option on the next update if you don't mind. (In reply to timp87 from comment #7) If the issue affects present port users, it should be addressed independently, such that it can be merged if it also affects quarterly users. What is the path to resolving this issue as reported? Created attachment 225982 [details]
port patch
remove PCRE option for www/squid as it's not supported officially
Hello, (In reply to Kubilay Kocak from comment #8) I was the one who proposed the PCRE patch back in 2017 (PR #223505), and currently the PCRE functionnality doesn't work at all (if someone has rules needing PCRE, squid don't start and spit errors). As nobody complained about this problem, I would say I am probably the only user being affected by this whole PCRE thing :-) (In reply to Pavel Timofeev from comment #9) Thanks for your patch! :-) Best Regards, Olivier (In reply to Pavel Timofeev from comment #9) www/squid-devel also have PCRE option. Should it be removed too? Created attachment 229503 [details]
Updated patch file
Remove PCRE option from both www/squid and www/squid-devel.
Maintainer timeout about approval request of attachment 229503 [details]. Take.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d6c9352b1e69c33ba0f4053fbd889f95b5e904bd commit d6c9352b1e69c33ba0f4053fbd889f95b5e904bd Author: Pavel Timofeev <timp87@gmail.com> AuthorDate: 2021-06-21 22:13:33 +0000 Commit: Yasuhiro Kimura <yasu@FreeBSD.org> CommitDate: 2021-12-14 02:07:50 +0000 www/{squid,squid-devel}: Remove PCRE option This option was added in 2017 and worked as is expected at the time. But it doesn't work any more. So remove it from squid ports. PR: 243291 Reported by: OlivierW Approved by: maintainer timeout (about modified version) www/squid-devel/Makefile | 7 ++----- www/squid/Makefile | 7 ++----- 2 files changed, 4 insertions(+), 10 deletions(-) Committed with modification about www/squid-devel. Thanks! |
