Bug 243443 (qtchooser-binaries)

Summary: [exp-run] Change misc/qtchooser binary linking
Product: Ports & Packages Reporter: Tobias C. Berner <tcberner>
Component: Individual Port(s)Assignee: Tobias C. Berner <tcberner>
Status: Closed FIXED    
Severity: Affects Only Me Flags: antoine: exp-run+
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 242905    
Attachments:
Description Flags
v1 none

Description Tobias C. Berner freebsd_committer 2020-01-19 08:47:26 UTC
Created attachment 210858 [details]
v1

Hi there

kde@ would like to ask an exp-run for a change to misc/qtchooser: 
- previously qtchooser installed a set of symlinks to itself for a set of known binaries (so ${LOCALBASE}/bin/qmake -> ${LOCALBASE}/bin/qtchooser). 

The attached patch changes this, so that the symlinks are created on pkg-install by the packages requiring them.


The patch is attached, and can also be found here:
https://people.freebsd.org/~tcberner/patches/qtchooser-slimdown.v1.diff


mfg Tobias
Comment 2 Tobias C. Berner freebsd_committer 2020-01-25 10:13:46 UTC
(In reply to Antoine Brodin from comment #1)
Bad timing: fixed it just now in r524024.

mfg Tobias
Comment 3 commit-hook freebsd_committer 2020-01-25 11:19:16 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jan 25 11:18:44 UTC 2020
New revision: 524026
URL: https://svnweb.freebsd.org/changeset/ports/524026

Log:
  Make dependency on linguisttools explicit

  The binary found by the cmake configure to check for its availability
  found the 'wrapper' installed by misc/qtchooser, which was present
  always (in short: it was broken). An upcoming change will change the
  behaviour of qtchooser not to install links if the binaries are not
  present.

  PR:		243443
  Reported by:	antoine

Changes:
  head/audio/drumkv1-lv2/Makefile
  head/audio/padthv1-lv2/Makefile
  head/audio/qmidictl/Makefile
  head/audio/samplv1-lv2/Makefile
  head/audio/synthv1-lv2/Makefile
Comment 4 Antoine Brodin freebsd_committer 2020-01-25 20:01:31 UTC
Exp-run looks fine
Comment 5 commit-hook freebsd_committer 2020-01-25 20:20:04 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jan 25 20:19:45 UTC 2020
New revision: 524129
URL: https://svnweb.freebsd.org/changeset/ports/524129

Log:
  misc/qtchooser: do not create unnecessary wrappers

  misc/qtchooser provides a wrapper binary bin/qtchooser, that when called with
  name foo, will lauch the corresponding binary from lib/qt${current_qt_version}/bin/foo.

  Previously qtchooser would install a list of 30-ish symlinks to itself automatically.
  Now we switch this around.

  qt-dist ports that define QT_BINARIES will now have a @postexec and @postunexec
  entry added to their plist to run the shell-script update-qtchooser-wrapper
  (installed by qtchooser).

  update-qtchooser-wrapper removes all symlinks to bin/qtcreator that have no
  corresponding binary in lib/qt*/bin, and readds links that are missing.

  Exp-run by:	antoine
  PR:		242905
  PR:		243443
  Reported by:	grarpamp@gmail.com
  Reviewed by:	adridg
  Differential Revision:	https://reviews.freebsd.org/D22991

Changes:
  head/Mk/Uses/qt-dist.mk
  head/comms/qt5-serialbus/Makefile
  head/devel/qt5-assistant/Makefile
  head/devel/qt5-buildtools/Makefile
  head/devel/qt5-core/Makefile
  head/devel/qt5-dbus/Makefile
  head/devel/qt5-designer/Makefile
  head/devel/qt5-help/Makefile
  head/devel/qt5-linguist/Makefile
  head/devel/qt5-linguisttools/Makefile
  head/devel/qt5-qdbus/Makefile
  head/devel/qt5-qdbusviewer/Makefile
  head/devel/qt5-qdoc/Makefile
  head/devel/qt5-qmake/Makefile
  head/devel/qt5-remoteobjects/Makefile
  head/devel/qt5-scxml/Makefile
  head/graphics/qt5-3d/Makefile
  head/graphics/qt5-pixeltool/Makefile
  head/graphics/qt5-wayland/Makefile
  head/misc/qtchooser/Makefile
  head/misc/qtchooser/files/patch-Makefile
  head/misc/qtchooser/files/update-qtchooser-wrapper.in
  head/misc/qtchooser/pkg-plist
  head/sysutils/qt5-qtdiag/Makefile
  head/sysutils/qt5-qtpaths/Makefile
  head/sysutils/qt5-qtplugininfo/Makefile
  head/textproc/qt5-xmlpatterns/Makefile
  head/www/qt5-webengine/Makefile
  head/x11/qt5-qev/Makefile
  head/x11-toolkits/qt5-declarative/Makefile
  head/x11-toolkits/qt5-gui/Makefile
  head/x11-toolkits/qt5-widgets/Makefile
Comment 6 Tobias C. Berner freebsd_committer 2020-01-25 20:20:28 UTC
Thanks for the exp-run.