Bug 243445

Summary: [maintainer update] japanese/lynx: Fix build error on -current and update to the latest stable release
Product: Ports & Packages Reporter: WATANABE Kazuhiro <CQG00620>
Component: Individual Port(s)Assignee: Wen Heping <wen>
Status: Closed FIXED    
Severity: Affects Only Me CC: wen
Priority: --- Keywords: buildisok
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
A svn diff for japanese/lynx
none
poudriere testport log on 12.1-RELEASE/amd64
none
poudriere testport log on 13.0-CURRENT/amd64 without the patch
none
poudriere testport log on 13.0-CURRENT/amd64 with the patch none

Description WATANABE Kazuhiro 2020-01-19 09:19:04 UTC
Created attachment 210862 [details]
A svn diff for japanese/lynx

(1) Update to the latest stable release.

(2) Use ncursesw instead of ncurses. (Makefile)

(3) Add IDN and SSL configuration options. (Makefile)

Recent lynx detects GNU Libidn automatically at build time and links it
if exists.  But japanese/lynx doesn't describe the dependency anywhere.
To fix the problem, add an IDN configuration option (off by default).  
Also adds a SSL option for convenience (off by default).

These codes are taken from www/{lynx,lynx-current}.  Thanks!

(4) Fix poudriere warnings about symlinks with an absolute pathname.
    (Makefile)

Poudriere testport log says:

| ====> Running Q/A tests (stage-qa)
| Warning: Bad symlink '/usr/local/share/lynx_help/COPYING' pointing to an absolute pathname '/usr/local/share/doc/lynx/COPYING'
| Warning: Bad symlink '/usr/local/share/lynx_help/COPYHEADER' pointing to an absolute pathname '/usr/local/share/doc/lynx/COPYHEADER'

To fix the problem, add a code to the post-install-DOCS-on target to override
the symlinks with a relative pathname.

This code is taken from www/lynx.  Thanks!

(5) Add LICENSE_FILE and modify CONFLICTS. (Makefile)
Comment 1 WATANABE Kazuhiro 2020-01-19 09:20:37 UTC
Created attachment 210863 [details]
poudriere testport log on 12.1-RELEASE/amd64
Comment 2 Automation User 2020-01-19 09:29:57 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/110533356
Comment 3 WATANABE Kazuhiro 2020-02-24 09:04:03 UTC
Due to the system ncurses update, japanese/lynx causes build error on
the latest -current:

 [package - head-amd64-default][japanese/lynx] Failed for ja-lynx-2.8.8.r2 in build
 https://docs.freebsd.org/cgi/getmsg.cgi?fetch=17019392+0+current/freebsd-pkg-fallout

This patch also fix the error, so please commit.
Comment 4 WATANABE Kazuhiro 2020-02-24 09:05:12 UTC
Created attachment 211882 [details]
poudriere testport log on 13.0-CURRENT/amd64 without the patch

Tested on FreeBSD-13.0-CURRENT-amd64-20200220-r358133.
Comment 5 WATANABE Kazuhiro 2020-02-24 09:06:11 UTC
Created attachment 211883 [details]
poudriere testport log on 13.0-CURRENT/amd64 with the patch

Tested on FreeBSD-13.0-CURRENT-amd64-20200220-r358133.
Comment 6 commit-hook freebsd_committer 2020-02-24 13:08:08 UTC
A commit references this bug:

Author: wen
Date: Mon Feb 24 13:07:33 UTC 2020
New revision: 526968
URL: https://svnweb.freebsd.org/changeset/ports/526968

Log:
  - Update to latest release
  - Use ncursesw instead of ncurses
  - Add IDN and SSL configuration options
  - Add LICENSE_FILE
  - Update CONFLICTS

  PR:		243445
  Submitted by:	CQG00620@nifty.ne.jp(maintainer)

Changes:
  head/japanese/lynx/Makefile
  head/japanese/lynx/distinfo