Bug 243478
| Summary: | [NEW PORT] x11-themes/gartoon-redux: A collection of icons for GNOME | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jonathan Chen <jonc> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | fernape, pi | ||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
portlint -AC complains a lot: FATAL: Makefile: extra item "MASTER_SITES" placed in the MAINTAINER section. WARN: Makefile: COMMENT is set externally to this port's Makefile, but this port is not configured as a slave port. FATAL: Makefile: extra item "MAINTAINER" placed in the LICENSE section. FATAL: Makefile: extra item "COMMENT" placed in the LICENSE section. WARN: Makefile: "LICENSE_FILE" has to appear earlier. WARN: Makefile: "LICENSE_FILE" has to appear earlier. WARN: Makefile: "LICENSE" has to appear earlier. WARN: Makefile: "LICENSE_FILE" has to appear earlier. WARN: Makefile: "BUILD_DEPENDS" has to appear earlier. WARN: Makefile: "USES" has to appear earlier. WARN: /home/pi/m/x11-themes/gartoon-redux/files/patch-configure: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. WARN: /home/pi/m/x11-themes/gartoon-redux/files/patch-links.pl: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. Created attachment 211291 [details]
gartoon-redux shar archive
Removed empty-line before MAINTAINER=
Created attachment 211389 [details]
gartoon-redux shar
Cleared last of portlint warnings.
Hi, is anything holding up this commit? What else do I need to do? (In reply to Jonathan Chen from comment #4) It's fine. I'm testing it. I'm hooking it up to x11-themes/gnome-icons too. Created attachment 211522 [details]
New patch. Port renamed
Added new patch.
- Rename port to gnome-icons-gartoon-redux as in similar ports
- Add gnome category
Hi Johnathan, Would you mind having a look at the new patch? Cheers! Looks good A commit references this bug: Author: fernape Date: Mon Feb 10 18:26:55 UTC 2020 New revision: 525728 URL: https://svnweb.freebsd.org/changeset/ports/525728 Log: new port: x11-themes/gnome-icons-gartoon-redux Improved variant of the well-known Gartoon theme for Gnome and Mate desktops. PR: 243478 Submitted by: jonc@chen.org.nz Changes: head/x11-themes/Makefile head/x11-themes/gnome-icons/Makefile head/x11-themes/gnome-icons-gartoon-redux/ head/x11-themes/gnome-icons-gartoon-redux/Makefile head/x11-themes/gnome-icons-gartoon-redux/distinfo head/x11-themes/gnome-icons-gartoon-redux/files/ head/x11-themes/gnome-icons-gartoon-redux/files/patch-configure head/x11-themes/gnome-icons-gartoon-redux/files/patch-install-links.pl head/x11-themes/gnome-icons-gartoon-redux/pkg-descr head/x11-themes/gnome-icons-gartoon-redux/pkg-plist Landed. Thanks for your patience! |
Created attachment 210906 [details] shar archive for x11-themes/gartoon-redux A Collection of Icons for GNOME.