Bug 243488

Summary: graphics/libdrm: Some plist enhancements
Product: Ports & Packages Reporter: Emmanuel Vadot <manu>
Component: Individual Port(s)Assignee: freebsd-x11 (Nobody) <x11>
Status: Closed Overcome By Events    
Severity: Affects Only Me CC: zeising
Priority: --- Flags: bugzilla: maintainer-feedback? (x11)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
graphics/libdrm: Fix include installation
none
graphics/libdrm: Add LEGACY option for old DRM drivers
none
graphics/libdrm: Only install tegra and vc4 headers for ARM* system
none
graphics/libdrm: Only install vmware and virtgpu driver on i386/amd64
none
graphics/libdrm: Fix include installation
none
graphics/libdrm: Add LEGACY option for old DRM drivers
none
graphics/libdrm: Only install tegra and vc4 headers for ARM* system
none
graphics/libdrm: Only install vmware and virtgpu driver on i386/amd64
none
graphics/libdrm: Fix include installation
none
graphics/libdrm: Fix include installation
none
graphics/libdrm: Fix include installation none

Description Emmanuel Vadot freebsd_committer 2020-01-21 19:35:23 UTC
Created attachment 210919 [details]
graphics/libdrm: Fix include installation

Few enhancement to the plist for libdrm.
This cleanups the old drivers include, a few i386/amd64 and arm ones.
Comment 1 Emmanuel Vadot freebsd_committer 2020-01-21 19:35:43 UTC
Created attachment 210920 [details]
graphics/libdrm: Add LEGACY option for old DRM drivers
Comment 2 Emmanuel Vadot freebsd_committer 2020-01-21 19:35:57 UTC
Created attachment 210921 [details]
graphics/libdrm: Only install tegra and vc4 headers for ARM* system
Comment 3 Emmanuel Vadot freebsd_committer 2020-01-21 19:36:10 UTC
Created attachment 210922 [details]
graphics/libdrm: Only install vmware and virtgpu driver on i386/amd64
Comment 4 Emmanuel Vadot freebsd_committer 2020-01-21 19:46:14 UTC
Created attachment 210924 [details]
graphics/libdrm: Fix include installation
Comment 5 Emmanuel Vadot freebsd_committer 2020-01-21 19:46:34 UTC
Created attachment 210925 [details]
graphics/libdrm: Add LEGACY option for old DRM drivers
Comment 6 Emmanuel Vadot freebsd_committer 2020-01-21 19:47:01 UTC
Created attachment 210926 [details]
graphics/libdrm: Only install tegra and vc4 headers for ARM* system
Comment 7 Emmanuel Vadot freebsd_committer 2020-01-21 19:47:16 UTC
Created attachment 210927 [details]
graphics/libdrm: Only install vmware and virtgpu driver on i386/amd64
Comment 8 Emmanuel Vadot freebsd_committer 2020-01-21 19:50:59 UTC
Created attachment 210928 [details]
graphics/libdrm: Fix include installation
Comment 9 Niclas Zeising freebsd_committer 2020-01-21 19:55:45 UTC
Some quick comments based on looking at the patch, I haven't tested yet.

You need to add PLUST_SUB=FOO_DRIVER="@comment" as needed in the !amd64 and !i386 case.
Comment 10 Emmanuel Vadot freebsd_committer 2020-01-21 20:28:22 UTC
Created attachment 210929 [details]
graphics/libdrm: Fix include installation

Address zeising@ comments.
Comment 11 Jan Beich freebsd_committer 2020-01-22 01:23:43 UTC
What's the rationale for limiting virtgpu DRM API to x86 architectures? drm-kmod doesn't support virtgpu while Linux "depends on DRM && VIRTIO && MMU" which is probably true for many architectures.
Comment 12 Emmanuel Vadot freebsd_committer 2020-01-22 15:24:08 UTC
Created attachment 210968 [details]
graphics/libdrm: Fix include installation

Always include virtgpu header.
Comment 13 Emmanuel Vadot freebsd_committer 2020-01-27 18:41:51 UTC
I have some other patches coming, let's delay this one for a bit.