Bug 243572

Summary: multimedia/librav1e: Fails to build with WITH_DEBUG=yes
Product: Ports & Packages Reporter: Benjamin Takacs <nimaje+fbz>
Component: Individual Port(s)Assignee: Jan Beich <jbeich>
Status: Closed FIXED    
Severity: Affects Some People Keywords: needs-qa
Priority: --- Flags: jbeich: maintainer-feedback+
jbeich: merge-quarterly+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
build log
none
remove ${CARGO_INSTALL_ARGS} jbeich: maintainer-approval+

Description Benjamin Takacs 2020-01-24 21:56:40 UTC
Created attachment 211018 [details]
build log

When having WITH_DEBUG=yes in make.conf build fails with:

error: Found argument '--debug' which wasn't expected, or isn't valid in this context

USAGE:
    cargo-cinstall install --destdir <destdir>

If I understand the Makefile right ${CARGO_INSTALL_ARGS} is normally empty for that port and only in the WITH_DEBUG case it will only contain '--debug' so removing ${CARGO_INSTALL_ARGS} in do-install could fix this issue
Comment 1 Benjamin Takacs 2020-01-24 21:58:04 UTC
Created attachment 211019 [details]
remove ${CARGO_INSTALL_ARGS}
Comment 2 Jan Beich freebsd_committer freebsd_triage 2020-01-25 15:31:53 UTC
Makes sense. cbuild doesn't have inconsistent defaults unlike cargo build vs. cargo install.
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-01-25 15:43:37 UTC
A commit references this bug:

Author: jbeich
Date: Sat Jan 25 15:43:22 UTC 2020
New revision: 524042
URL: https://svnweb.freebsd.org/changeset/ports/524042

Log:
  multimedia/librav1e: unbreak build WITH_DEBUG

  error: Found argument '--debug' which wasn't expected, or isn't valid in this context

  PR:		243572
  Submitted by:	nimaje+fbz@bureaucracy.de

Changes:
  head/multimedia/librav1e/Makefile
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-01-25 15:44:38 UTC
A commit references this bug:

Author: jbeich
Date: Sat Jan 25 15:44:20 UTC 2020
New revision: 524043
URL: https://svnweb.freebsd.org/changeset/ports/524043

Log:
  MFH: r524042

  multimedia/librav1e: unbreak build WITH_DEBUG

  error: Found argument '--debug' which wasn't expected, or isn't valid in this context

  PR:		243572
  Submitted by:	nimaje+fbz@bureaucracy.de
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2020Q1/
  branches/2020Q1/multimedia/librav1e/Makefile