Bug 243578
| Summary: | audio/audacity: Update distinfo (upstream git tag 2.3.3 changed) | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jack <xxjack12xx> | ||||||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Many People | CC: | pi, tatsuki_makino, xxjack12xx | ||||||||
| Priority: | --- | Keywords: | needs-qa | ||||||||
| Version: | Latest | Flags: | xxjack12xx:
maintainer-feedback+
|
||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 211024 [details]
Updated patch with fixed offset patchfiles.
Jack, can you clarify what happened upstream. Did the commit hash that the 2.3.3 repository tag pointed to get moved? This "appears to be the case": https://sourceforge.net/p/audacity/mailman/message/36863277/ When tarballs change (but version numbers do not), the standard recommendation is covered here in the Porters Handbook: https://www.freebsd.org/doc/en/books/porters-handbook/book.html#dads-rerolling-distfiles In particular, this part is marked as IMPORTANT, and needs to be included here, and likely the primary contributor to the delay getting this change committed: "Be sure to summarize the differences in the PR and commit log, so that other people know that nothing bad has happened." If you can provide that information, it will go a long way to progressing resolution of this issue. I had reported to audacity that the version showed as 2.3.3-alpha in the release tarball. When the tar changed, I rebuilt it and it now shows as 2.3.3 release. The old tar is no longer available to download so I can't do a diff but clearly the release version changed from alpha to release in the about. distcache.FreeBSD.org still has SHA256 (audacity-audacity-Audacity-2.3.3_GH0.tar.gz) = 9ab6c8989e21165b86aad80b7e6691015cb5b0c91ab77e6170d7192f840313a8 file. The difference between 9ab6c8989e21165b86aad80b7e6691015cb5b0c91ab77e6170d7192f840313a8 and 404e6c49693dedc94212fc5525974058d848536025e19da31359ae02babe8bd7 is the same diff as git diff eb2161d 008d8d8 Created attachment 211468 [details]
diff between the old and new tar.
Any update on when this can be committed or if anything else is needed to get the port fetchable? Committed, thanks! A commit references this bug: Author: pi Date: Tue Feb 25 06:37:49 UTC 2020 New revision: 527065 URL: https://svnweb.freebsd.org/changeset/ports/527065 Log: audio/audacity: delete unneeded patches, update distinfo PR: 244253, 243578 Submitted by: Jack <xxjack12xx@gmail.com> (maintainer) Changes: head/audio/audacity/Makefile head/audio/audacity/distinfo head/audio/audacity/files/patch-include_audacity_Types.h head/audio/audacity/files/patch-src_prefs_PrefsDialog.cpp |
Created attachment 211023 [details] Update distinfo to reflect alpha to release version Appears the tar has updated from showing an alpha version to 2.3.3 release.