Bug 243713

Summary: BHyve VM name length
Product: Base System Reporter: misho
Component: bhyveAssignee: freebsd-virtualization (Nobody) <virtualization>
Status: Closed DUPLICATE    
Severity: Affects Many People CC: markj, meka
Priority: ---    
Version: CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch to extend name of VMs none

Description misho 2020-01-29 19:37:22 UTC
Created attachment 211175 [details]
Patch to extend name of VMs

I believe that is good idea to have more than 31 chars for VM name.
Comment 1 Goran Mekić 2020-01-29 22:36:15 UTC
I'm just curious, how did you decide what the new length should be?
Comment 2 misho 2020-01-29 23:23:34 UTC
Our colleagues from different department tries to request from server VM instance through RPC service. They wants to have name of VM built from UUID string.
I check that isn't impossible for creation and found that 32 bytes are created without problem. 
I offer to them to remove dashes from UUID. Then they will have 32 chars name.
Ok ... tools can handle it, but kernel cannot start it. Then I found that if the name is 31 chars all is ok.
This is brake point which drive me to start chasing of this issue.

I found where are made checks for length of VM name and variable which contains the name of VM.
Decision was based on several considerations
- I like all my variables to be rounded of machine word.
- We should not grow up to much, because I predict that many users already have something like monitoring software which drawing something in tables. 

This is something like explanation ... :)
Comment 3 Mark Johnston freebsd_committer freebsd_triage 2020-01-29 23:31:41 UTC
I believe this has already been fixed:
https://svnweb.freebsd.org/changeset/base/349948

Note that the length on stable/12 is still quite small.
Comment 4 Mark Johnston freebsd_committer freebsd_triage 2020-02-05 00:13:50 UTC

*** This bug has been marked as a duplicate of bug 234134 ***