Bug 243793
| Summary: | www/mod_log_sql2: fix for FreeBSD's PID > 65535 when 'LogSQLCreateTables On' | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Tommy P <tommyhp2> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Bernard Spil <brnrd> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Only Me | CC: | brnrd, joneum, tommyhp2 | ||||||||||||
| Priority: | --- | Keywords: | needs-qa, patch | ||||||||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(apache) |
||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Tommy P
2020-02-02 09:11:33 UTC
Created attachment 211268 [details]
contrib/create_tables.sql
Created attachment 211269 [details]
mod_log_sql_dbi.c
Created attachment 211270 [details]
mod_log_sql_mysql.c
Created attachment 211271 [details]
mod_log_sql_pgsql.c
Please give a detailed description. Are there any errors? If so, which ones? Please a patch, not many small ones. Thanks :-) Created attachment 212322 [details]
combined patches for SQL and *.c files
(In reply to Jochen Neumeister from comment #5) Hi Jochen, There aren't any errors in the logs that I could see. I did noticed the SQL file, from the setting LogSQLPreserveFile, got bigger when the DB and web servers have been running for a long time. When I tried to enter the data manually by running that SQL file, all of the rows failed because the data is larger (> 65535) than column (child_pid) allowed (unsigned smallint). The patches allow the setting LogSQLCreateTables to work as intended. I don't recall the max limit of PID on FreeBSD 11.x but on 12.1-RELEASE, I see it goes up to 99922 as of this writing. Regards, Tommy A commit references this bug: Author: brnrd Date: Thu Aug 6 15:09:19 UTC 2020 New revision: 544278 URL: https://svnweb.freebsd.org/changeset/ports/544278 Log: www/mod_log_sql: Fix PID > 65535 * PID > 65535 when 'LogSQLCreateTables On' [1] * Fix WWW address * 2 suffix (for Apache 2) is redundant, remove PR: 243793 [1] Submitted by: Tommy P <tommyhp2 gmail com> Changes: head/MOVED head/www/Makefile head/www/mod_log_sql/ head/www/mod_log_sql/Makefile head/www/mod_log_sql/pkg-descr head/www/mod_log_sql2/ Thanks for the patch! |
