Bug 243811
| Summary: | www/webhook: fix build on aarch64 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Mikael Urankar <mikael> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | manu, stb | ||||
| Priority: | --- | Flags: | stb:
maintainer-feedback+
|
||||
| Version: | Latest | ||||||
| Hardware: | arm64 | ||||||
| OS: | Any | ||||||
| URL: | http://thunderx1.nyi.freebsd.org/data/head-arm64-default/p521042_s356139/logs/errors/webhook-2.6.9_1.log | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 242312 | ||||||
| Attachments: |
|
||||||
Would you be so kind to briefly explain what this change is doing? Have you submitted a PR upstream? The patch updates golang.org/x/sys with a version that supports FreeBSD arm64. I have a lot of ports to fix, not sure I'll be able to open a PR in every case, can you open a PR upstream? Is this a general issue, or is it FreeBSD specific? Can I read more about the issue somewhere? It's specific to FreeBSD/aarch64. Support for go on FreeBSD/aarch64 was added recently : https://github.com/golang/go/issues/24715. I'm not very familiar with the go ecosystem but it seems that every project use a random golang.org/x/sys/unix version, some of them pick a really old version of sys/unix or x/net where FreeBSD/aarch64 is not a thing. This is the 'master' pr for 'go' problem on aarch64 : https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242312 Approved-by: manu (mentor) A commit references this bug: Author: mikael Date: Mon Feb 24 20:01:31 UTC 2020 New revision: 527046 URL: https://svnweb.freebsd.org/changeset/ports/527046 Log: www/webhook: unbreak on aarch64 Unbreak by pulling in golang.org/x/sys@fead7900131 to fix build on aarch64 PR: 243811 Approved by: stb@lassitu.de (maintainer), manu (mentor) Changes: head/www/webhook/Makefile head/www/webhook/distinfo |
Created attachment 211287 [details] patch # github.com/adnanh/webhook/vendor/golang.org/x/sys/unix vendor/golang.org/x/sys/unix/cap_freebsd.go:18:23: undefined: CAP_RIGHTS_VERSION_00 vendor/golang.org/x/sys/unix/cap_freebsd.go:19:23: undefined: CAP_RIGHTS_VERSION_00 vendor/golang.org/x/sys/unix/cap_freebsd.go:46:21: undefined: CapRights vendor/golang.org/x/sys/unix/cap_freebsd.go:50:24: undefined: CapRights vendor/golang.org/x/sys/unix/cap_freebsd.go:55:27: undefined: CapRights vendor/golang.org/x/sys/unix/cap_freebsd.go:90:29: undefined: CapRights vendor/golang.org/x/sys/unix/syscall_unix_gc.go:12:6: missing function body vendor/golang.org/x/sys/unix/syscall_unix_gc.go:13:6: missing function body vendor/golang.org/x/sys/unix/syscall_unix_gc.go:14:6: missing function body vendor/golang.org/x/sys/unix/syscall_unix_gc.go:15:6: missing function body