Bug 243838

Summary: Increase vale switch limits
Product: Base System Reporter: Mateusz Kwiatkowski <kwiat3k>
Component: kernAssignee: Vincenzo Maffione <vmaffione>
Status: Closed FIXED    
Severity: Affects Some People CC: afedorov, luigi, lwhsu, net, vmaffione
Priority: --- Keywords: feature
Version: 12.1-RELEASE   
Hardware: Any   
OS: Any   
URL: https://reviews.freebsd.org/D23546

Description Mateusz Kwiatkowski 2020-02-03 09:34:02 UTC
Vale switches are limited as per man page vale(4):
   LIMITS
     vale currently supports up	to 4 switches, 16 ports	per switch, with 1024
     buffers per port.	These hard limits will be changed to sysctl variables
     in	future releases.

Nowadays it's easy to hit these limits with bhyve machines and/or jails with virtualized network stacks.
It would be nice to increase these limits or make them configurable by sysctl variables.
Comment 1 Aleksandr Fedorov freebsd_committer freebsd_triage 2020-02-06 11:23:42 UTC
The vale(4) man page contains outdated information.

Current values: 8 switches, 255 ports.

https://svnweb.freebsd.org/base/head/sys/dev/netmap/netmap_bdg.h?view=markup#l76
Comment 2 Mateusz Kwiatkowski 2020-02-06 12:47:48 UTC
That's great news. Could you please update the man page then? Thank you.
Comment 3 Vincenzo Maffione freebsd_committer freebsd_triage 2020-02-06 21:24:34 UTC
https://reviews.freebsd.org/D23546
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-02-07 19:26:56 UTC
A commit references this bug:

Author: vmaffione
Date: Fri Feb  7 19:26:27 UTC 2020
New revision: 357663
URL: https://svnweb.freebsd.org/changeset/base/357663

Log:
  netmap: improve netmap(4) and vale(4) man pages

  Clean up obsolete sysctl descriptions and add missing ones.

  PR:		243838
  Reviewed by:	bcr
  MFC after:	1 week
  Differential Revision:	https://reviews.freebsd.org/D23546

Changes:
  head/share/man/man4/netmap.4
  head/share/man/man4/vale.4
  head/sys/dev/netmap/netmap_kern.h
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-02-15 11:43:01 UTC
A commit references this bug:

Author: vmaffione
Date: Sat Feb 15 11:42:14 UTC 2020
New revision: 357960
URL: https://svnweb.freebsd.org/changeset/base/357960

Log:
  MFC r357663

  netmap: improve netmap(4) and vale(4) man pages

  Clean up obsolete sysctl descriptions and add missing ones.

  PR:             243838
  Reviewed by:    bcr
  Differential Revision:  https://reviews.freebsd.org/D23546

Changes:
_U  stable/12/
  stable/12/share/man/man4/netmap.4
  stable/12/share/man/man4/vale.4
  stable/12/sys/dev/netmap/netmap_kern.h
Comment 6 commit-hook freebsd_committer freebsd_triage 2020-02-15 12:06:06 UTC
A commit references this bug:

Author: vmaffione
Date: Sat Feb 15 12:05:12 UTC 2020
New revision: 357961
URL: https://svnweb.freebsd.org/changeset/base/357961

Log:
  MFC r357663

  netmap: improve netmap(4) and vale(4) man pages

  Clean up obsolete sysctl descriptions and add missing ones.

  PR:             243838
  Reviewed by:    bcr
  Differential Revision:  https://reviews.freebsd.org/D23546

Changes:
_U  stable/11/
  stable/11/share/man/man4/netmap.4
  stable/11/share/man/man4/vale.4
  stable/11/sys/dev/netmap/netmap_kern.h
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2020-02-17 02:11:03 UTC
@Vincenzo Is the man page change the only changes required to resolve this issue as reported, or are there other changes?