Bug 243905
| Summary: | misc/sword: clean Makefile and take maintainership | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Lorenzo Salvadore <salvadore> | ||||||||
| Component: | Individual Port(s) | Assignee: | Mateusz Piotrowski <0mp> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | 0mp | ||||||||
| Priority: | --- | Keywords: | buildisok | ||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/115251656 Are you sure that the "USE_CXXSTD= gnu++11" has to go? Also, could you lint the file with portfmt and portclippy? Created attachment 211385 [details]
sword adoption 2
Fixed with the suggested tools (I did not know about them, I knew only about portlint: they are great! I think I have never read about them in the porter handbook) and tested successfully with poudriere on {11.3,12.1}-RELEASE {i386,amd64}.
I confirm that I believe USE_STDCXX can safely be removed: I grepped /usr/ports/Mk for such a variable name but I could not find it. I guess it was replaced long time ago by USES= compiler. Anyway, if the variable is not recognized, it cannot have any effect and it is safe to remove it.
A commit references this bug: Author: 0mp Date: Thu Feb 6 09:19:48 UTC 2020 New revision: 525370 URL: https://svnweb.freebsd.org/changeset/ports/525370 Log: misc/sword: Clean Makefile and assign to new maintainer Apart from style changes, also remove broken link from MASTER_SITES. PR: 243905 Submitted by: salvadore@ Changes: head/misc/sword/Makefile Done! Thanks a lot! BTW, the website link in pkg-descr is broken. You may want to want to try to find a new link (if it exists). Cheers! Created attachment 211407 [details]
sword fix WWW
Thanks!
I found the right website and updated it in the new attachment. Thanks for noticing the broken link.
(In reply to Lorenzo Salvadore from comment #7) Nice! Thanks a lot! A commit references this bug: Author: 0mp Date: Thu Feb 6 15:53:55 UTC 2020 New revision: 525383 URL: https://svnweb.freebsd.org/changeset/ports/525383 Log: Update WWW PR: 243905 Submitted by: salvadore@ Changes: head/misc/sword/pkg-descr |
Created attachment 211379 [details] sword adoption Patch tested successfully with poudriere on {11.3,12.1}-RELEASE and {i386,amd64}.