Bug 243917

Summary: security/munge: rc script sends unnecessary SIGKILL to stop munged daemon
Product: Ports & Packages Reporter: Chris Dunlap <chris.m.dunlap>
Component: Individual Port(s)Assignee: Muhammad Moinur Rahman <bofh>
Status: Closed FIXED    
Severity: Affects Some People Flags: bugzilla: maintainer-feedback? (bofh)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
send sigterm in munged_stop() to stop munged daemon none

Description Chris Dunlap 2020-02-06 02:07:24 UTC
Created attachment 211400 [details]
send sigterm in munged_stop() to stop munged daemon

The rc script stops the munged daemon via kill -9.  This prevents munged from cleaning up, writing its prng seedfile, and removing its socket/lockfile/pidfile.

Update munged_stop() to simply send SIGTERM to stop munged.  The subsequent sleep is also unnecessary.  Patch attached.  Tested on 11.3-RELEASE-p6 and 12.1-RELEASE-p2.
Comment 1 commit-hook freebsd_committer 2020-02-12 22:00:37 UTC
A commit references this bug:

Author: bofh
Date: Wed Feb 12 22:00:06 UTC 2020
New revision: 525976
URL: https://svnweb.freebsd.org/changeset/ports/525976

Log:
  security/munge: Fix rc script

  PR:		243917
  Submitted by:	chris.m.dunlap@gmail.com

Changes:
  head/security/munge/Makefile
  head/security/munge/files/munged.in