Bug 243977

Summary: [NEW PORT] print/brlaser: CUPS driver for Brother laser printers
Product: Ports & Packages Reporter: Vincent DEFERT <20.100>
Component: Individual Port(s)Assignee: Kubilay Kocak <koobs>
Status: Closed FIXED    
Severity: Affects Only Me Keywords: feature
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Shell Archive of the port none

Description Vincent DEFERT 2020-02-08 10:23:50 UTC
Created attachment 211470 [details]
Shell Archive of the port
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-02-08 10:56:51 UTC
Thank you for your new port submission Vincent.

On initial review, the port as submitted doesn't pass portlint, failing a couple of basic checks.

I will resolve these myself, but for future reference, it helps immensely to have ports (new and updates) pass QA prior to submitting them here.

For more information and instructions, see:

https://www.freebsd.org/doc/en/books/porters-handbook/testing.html

If you need help or support with your ports contributions, or getting testing/QA going, don't hesitate to /join #freebsd-ports on freenode IRC with your questions
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2020-02-08 10:57:42 UTC
The failing checks were:

use a tab (not space) after a variable name (several times)

and

WARN: /usr/home/koobs/repos/freebsd/ports/print/brlaser/pkg-plist: There are only 2 items in the plist.  Consider using PLIST_FILES instead of pkg-plist when installing less than 6 items.

I will run this port through additional QA and report back on results
Comment 3 commit-hook freebsd_committer 2020-02-08 12:51:16 UTC
A commit references this bug:

Author: koobs
Date: Sat Feb  8 12:50:19 UTC 2020
New revision: 525546
URL: https://svnweb.freebsd.org/changeset/ports/525546

Log:
  [NEW PORT] print/brlaser: Brother laser printer driver

  brlaser is a CUPS driver for Brother laser printers.

  Although most Brother printers support a standard printer language such
  as PCL or PostScript, not all do. If you have a monochrome Brother laser
  printer (or multi-function device) and the other open source drivers
  don't work, this one might help.

  WWW: https://github.com/pdewacht/brlaser/

  PR:		243977
  Submitted by:	Vincent DEFERT <20.100 defert com>

Changes:
  head/print/Makefile
  head/print/brlaser/
  head/print/brlaser/Makefile
  head/print/brlaser/distinfo
  head/print/brlaser/pkg-descr
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2020-02-08 12:54:11 UTC
Committed with minor changes:

- fix spaces -> tabs
- use PLIST_FILES
- Tweak COMMENT (to match upstream)
- Remove copyrights/license info from pkg-descr

Thanks Vincent!