Bug 243994

Summary: editors/vscode: Fails to build: Error: getaddrinfo EAI_FAIL marketplace.visualstudio.com fetching vscode-linux-x64-min (network fetch attempts)
Product: Ports & Packages Reporter: Robert Cina <transitive>
Component: Individual Port(s)Assignee: Luca Pizzamiglio <pizzamig>
Status: Closed FIXED    
Severity: Affects Only Me CC: pizzamig, tagattie
Priority: --- Keywords: needs-patch, regression
Version: LatestFlags: tagattie: maintainer-feedback+
koobs: merge-quarterly-
Hardware: amd64   
OS: Any   

Description Robert Cina 2020-02-08 23:55:42 UTC
The port editors/vscode fails to build for me using poudriere on 12-stable with an error at vscode-linux-x64-min.
 
Below is the error i am receiving:

[23:49:06] Downloading extension: [33mms-vscode.node-debug2@1.41.3[39m ...
[23:49:06] Downloading extension: [33mms-vscode.references-view@0.0.42[39m ...
[23:49:06] 'vscode-linux-x64-min' errored after 6.05 min
[23:49:06] Error: getaddrinfo EAI_FAIL marketplace.visualstudio.com marketplace.visualstudio.com:443
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:56:26)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
*** Error code 1

Stop.
make: stopped in /usr/ports/editors/vscode
=>> Cleaning up wrkdir
===>  Cleaning for vscode-1.41.1
build of editors/vscode | vscode-1.41.1 ended at Sat Feb  8 18:49:07 EST 2020
build time: 00:11:03
!!! build failure encountered !!!
Comment 1 Hiroki Tagato freebsd_committer freebsd_triage 2020-02-09 05:08:15 UTC
(In reply to Robert Cina from comment #0)

There is a change missing in the latest commit which causes this error. Renaming a file as follows should fix the problem:

cd ${FILESDIR}
mv extra-patch-build_gulpfile.extensions.js patch-build_gulpfile.extensions.js

I'm now asking a ports committer via GitHub[1] to commit the change.

[1] https://github.com/tagattie/FreeBSD-VSCode/issues/17
Comment 2 Luca Pizzamiglio freebsd_committer freebsd_triage 2020-02-09 11:56:42 UTC
On it
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-02-09 12:00:10 UTC
A commit references this bug:

Author: pizzamig
Date: Sun Feb  9 11:59:55 UTC 2020
New revision: 525651
URL: https://svnweb.freebsd.org/changeset/ports/525651

Log:
  editors/vscode: fix a patch rename

  A patch moved from extra-patch to patch and this change went lost.
  Fix it.

  PR:		243994
  Submitted by:	maintainer (via github)
  Reported by:	Robert Cina

Changes:
  head/editors/vscode/files/extra-patch-build_gulpfile.extensions.js
  head/editors/vscode/files/patch-build_gulpfile.extensions.js