Bug 244008

Summary: [exp-run] Simplify Mk/bsd.gcc.mk
Product: Ports & Packages Reporter: Gerald Pfeifer <gerald>
Component: Ports FrameworkAssignee: Gerald Pfeifer <gerald>
Status: Closed FIXED    
Severity: Affects Many People CC: ports-bugs
Priority: --- Flags: antoine: exp-run+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Proposed patch none

Description Gerald Pfeifer freebsd_committer 2020-02-09 19:59:10 UTC
Created attachment 211518 [details]
Proposed patch

Log:
Significantly simplify the logic to determine which port (or base version)
of GCC to use based on the specification of USE_GCC.  This is based on the
observation that we now only have a single version of GCC in base, namely
GCC 4.2, which is not in ports any longer.  And we limit the choice to
either the specific version requested or the default version of GCC in
the ports tree; i.e., we no longer consider any installed port of any
version in between (which is a fringe case extremely few, if any, users
would have experienced, and then only outside a clean build environment
in any case).

Streamline some debugging output accordingly.  Overall this removes some
25 lines of largely complex logic.
Comment 1 Antoine Brodin freebsd_committer 2020-02-18 09:07:07 UTC
Exp-run looks fine
Comment 2 Gerald Pfeifer freebsd_committer 2020-02-22 11:13:53 UTC
Thank you, Antoine!

And, grr, I missed to connect this via the commit message:

PR:             244008 
Tested by:      antoine (exp-run)

Author: gerald
Date: Sat Feb 22 10:15:04 2020
New Revision: 526751
URL: https://svnweb.freebsd.org/changeset/ports/526751

Log:
  Significantly simplify the logic to determine which port (or base version)
  of GCC to use based on the specification of USE_GCC.
  
  This is based on the observation that we now only have a single version
  of GCC in base, namely GCC 4.2, which is not in ports any longer.  And
  we limit our choice to either the specific version requested or the
  default version of GCC in the ports tree; i.e., we no longer consider
  an installed port of any version in between (which is a fringe case
  extremely few, if any, users would have experienced, and then only
  outside a clean build environment in any case).
  
  Streamline some debugging output accordingly.
  
  Overall this removes some 25 lines of largely complex logic.

Modified:
  head/Mk/bsd.gcc.mk