Bug 244153

Summary: Typo error in top manpage
Product: Base System Reporter: Zsolt Udvari <uzsolt>
Component: binAssignee: Mark Johnston <markj>
Status: Closed FIXED    
Severity: Affects Many People CC: fnoyanisi, markj
Priority: --- Keywords: easy, patch
Version: 12.0-RELEASE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch for top.1 none

Description Zsolt Udvari freebsd_committer freebsd_triage 2020-02-16 04:37:27 UTC 
The top's man page:
synopsis: ... [-m cpu|io] ...
But the description doesn't contain this option but contains -display:
-display
	     Display either 'cpu' or 'io' statistics.  Default is 'cpu'.

I think the '-display' should be '-m'.
Comment 1 fehmi noyan isi 2020-02-17 02:10:32 UTC 
Created attachment 211702 [details]
Patch for top.1

Right, the top.c source file does not list any long options for "display"

Attached the patch for the fix. 

fnoyanisi@patch:/usr/src/usr.bin/top $ uname -a
FreeBSD patch 13.0-CURRENT FreeBSD 13.0-CURRENT #0 r357606: Thu Feb  6 04:40:35 UTC 2020     root@releng1.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC  amd64
fnoyanisi@patch:/usr/src/usr.bin/top $ svnlite info
Path: .
Working Copy Root Path: /usr/src
URL: https://svn.freebsd.org/base/head/usr.bin/top
Relative URL: ^/head/usr.bin/top
Repository Root: https://svn.freebsd.org/base
Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
Revision: 358012
Node Kind: directory
Schedule: normal
Last Changed Author: philip
Last Changed Rev: 355978
Last Changed Date: 2019-12-21 18:03:21 +1300 (Sat, 21 Dec 2019)

fnoyanisi@patch:/usr/src/usr.bin/top $
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-04-03 13:36:19 UTC 
A commit references this bug:

Author: markj
Date: Fri Apr  3 13:35:44 UTC 2020
New revision: 359594
URL: https://svnweb.freebsd.org/changeset/base/359594

Log:
  Fix the description of the -m flag in top.1.

  PR:		244153
  Submitted by:	fehmi noyan isi <fnoyanisi@yahoo.com>
  MFC after:	3 days

Changes:
  head/usr.bin/top/top.1
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-04-03 14:48:27 UTC 
A commit references this bug:

Author: markj
Date: Fri Apr  3 14:47:40 UTC 2020
New revision: 359597
URL: https://svnweb.freebsd.org/changeset/base/359597

Log:
  Fix up r359594: -m takes an argument.

  PR:		244153
  Reported by:	0mp
  MFC with:	r359594

Changes:
  head/usr.bin/top/top.1
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-04-06 14:57:19 UTC 
A commit references this bug:

Author: markj
Date: Mon Apr  6 14:56:19 UTC 2020
New revision: 359658
URL: https://svnweb.freebsd.org/changeset/base/359658

Log:
  MFC r359594, r359597:
  Fix the description of the -m flag in top.1.

  PR:	244153

Changes:
_U  stable/12/
  stable/12/usr.bin/top/top.1
Comment 5 Mark Johnston freebsd_committer freebsd_triage 2020-04-06 14:57:54 UTC 
Thanks for the report.