Bug 244299

Summary: mail/exim: does not compile with AUTH_RADIUS=on
Product: Ports & Packages Reporter: Victor Sudakov <vas>
Component: Individual Port(s)Assignee: Dima Panov <fluffy>
Status: Closed FIXED    
Severity: Affects Some People CC: fluffy, vas
Priority: --- Flags: bugzilla: maintainer-feedback? (vsevolod)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Poudriere build log none

Description Victor Sudakov 2020-02-22 06:34:34 UTC
Created attachment 211825 [details]
Poudriere build log

call_radius.c:189:13: error: expected expression
  *errptr = string_sprintf("RADIUS: can't initialise libradius");
            ^
./../local_scan.h:193:64: note: expanded from macro 'string_sprintf'
        string_sprintf_trc(fmt, US __FUNCTION__, __LINE__, __VA_ARGS__)
                                                                      ^
1 error generated.
*** Error code 1

Stop.
make[3]: stopped in /wrkdirs/usr/ports/mail/exim/work/exim-4.93/build-FreeBSD-amd64/auths
*** Error code 1

Workaround: disable AUTH_RADIUS
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-02-24 15:33:19 UTC
A commit references this bug:

Author: fluffy
Date: Mon Feb 24 15:32:55 UTC 2020
New revision: 526974
URL: https://svnweb.freebsd.org/changeset/ports/526974

Log:
  mail/exim: unbreak with AUTH_RADIUS

  - bump PORTREVISION for radius users only
  - allow to build with net/freeradius-client instead of abandonware net/radiusclient-ng
  - Do not invoke printf-like function without parameter in call_radius.c
  With exim 4.93, string_sprintf() requires at least two arguments
  - take maintainership, discussed with vsevolod@ via private mail

  PR:		244287, 244299
  Reported by:	pi, Victor Sudakov
  Approved by:	maintainer

Changes:
  head/mail/exim/Makefile
  head/mail/exim/files/patch-src-auths-call_radius.c
Comment 2 Dima Panov freebsd_committer freebsd_triage 2020-02-24 15:34:49 UTC
Fixed in r526974