Bug 244304
| Summary: | net-mgmt/netdata: add godplugin option | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dries Michiels <driesm> | ||||||
| Component: | Individual Port(s) | Assignee: | Matthias Andree <mandree> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | diizzy, driesm, mandree, mmokhi | ||||||
| Priority: | --- | Keywords: | buildisok, patch | ||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Bug Depends on: | 244291, 244323 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/124236653 Hi Dries! I'm a bit confused about what this is supposed to. Are you trying to provide a "simple" way of installing the go-plugins? This makes the netdata port install netdata-go as dependency. Right now the python plugin is included in the netdata repo upstream by default. Meaning it is always installed when installing netdata. This is not the case for the god.plugin. And as netdata is in the progress to convert all python plugins to go plugins, it makes sense to enable the option by default. It's more consistent to follow upstream rather than diverging and there are a lot cases where you don't need the go plugins at all also go is a pretty large dependency. Until upstream decides to fully change I think it's better to display a notice like other ports does (like when python extensions are available in the tree) for addtional funtionality via other ports. We could do that! I don't really have any hidden agenda's although if we don't want to diverge from upstream we should actually enable it. On there github README, https://github.com/netdata/go.d.plugin, they explicitly state it should be shipped with netdata. "Install Shipped with Netdata." But at least I would like to have the option toggler thingy :-D, not necessarily enabled by default. Can you rebase it on top of https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244323 (v2) and not make it default? There's no need to for any addtional messages since it's already a meny option. GODPLUGIN_DESC should probably just say External go.d plugin as that's what upstream referers it as https://github.com/netdata/go.d.plugin/ Created attachment 213016 [details]
netdata.diff
Rebase and default to off.
take, maintainer timeout Thanks Dries and Daniel, committed as r530686 A commit references this bug: Author: mandree Date: Sat Apr 4 16:00:08 UTC 2020 New revision: 530686 URL: https://svnweb.freebsd.org/changeset/ports/530686 Log: net-mgmt/netdata: add GOPLUGIN option (default off)... ...to create a run-time dependency on net-mgmt/netdata-go. PR: 244304 Submitted by: Dries Michiels <driesm.michiels@gmail.com> Reviewed by: daniel.engberg.lists@pyret.net Approved by: maintainer timeout (mmohki@, 42 days) Changes: head/net-mgmt/netdata/Makefile |
Created attachment 211829 [details] netdata.diff This links the package with the godplugin. Netdata is in the process of migrating all python plugins to go (so default on option to future proof and help in the transition). QA: portlint -AC testport option on current amd64