Bug 244323

Summary: net-mgmt/netdata: Update to 1.20.0
Product: Ports & Packages Reporter: Dries Michiels <driesm>
Component: Individual Port(s)Assignee: Matthias Andree <mandree>
Status: Closed FIXED    
Severity: Affects Only Me CC: diizzy, mandree
Priority: --- Flags: bugzilla: maintainer-feedback? (mmokhi)
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 244304    
Attachments:
Description Flags
netdata.diff
none
Patch v2 none

Description Dries Michiels freebsd_committer freebsd_triage 2020-02-22 20:30:38 UTC 
Created attachment 211843 [details]
netdata.diff

Changelog: https://github.com/netdata/netdata/releases/tag/v1.20.0
A lot of plugins are switching to go and are not present in this release anymore. Best to commit with https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244304.

Removed deprecated bash collectors apache, cpu_apps, cpufreq, exim, hddtemp, load_average, mem_apps, mysql, nginx, phpfpm, postfix, squid, tomcat #7962 (ilyam8). If you were still using one of these collectors with custom configurations, you can find the new collector that replaces it in the supported collectors list.
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2020-03-05 08:39:13 UTC 
Hi,

I have a patch for netdata 1.20.0 with a few addtional changes:

Makefile:
CFLAGS --> Remove "-I${LOCALBASE}/include"
LIBS --> Remove completely (not needed)
CONFIGURE_ARGS --> Add "--disable-unit-tests" (not used)

Patches adopted from Debian:
https://git.progress-linux.org/distributions/engywuck-backports/packages/netdata/tree/debian/patches/debian/0001-use-system-python.patch
https://git.progress-linux.org/distributions/engywuck-backports/packages/netdata/tree/debian/patches/debian/0008-remove-update-button.patch
https://git.progress-linux.org/distributions/engywuck-backports/packages/netdata/tree/debian/patches/debian/0009-remove-social-media-buttons.patch
https://git.progress-linux.org/distributions/engywuck-backports/packages/netdata/tree/debian/patches/debian/0012-remove-signin.patch

0001 --> Removes bundled versions or urllib3 and yaml (I've adapted the Makefile and to use these libraries from the tree instead and updated pkg-plist)
0008,0009,0012 are mainly cosmetical changes but removes some annoyances

Would it be okay if I attached my patch?
Comment 2 Dries Michiels freebsd_committer freebsd_triage 2020-03-05 19:18:07 UTC 
Sure, go ahead. :-)
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2020-03-06 00:31:02 UTC 
Created attachment 212172 [details]
Patch v2

Initial work done by Dries Michiels
Clean up CFLAGS variable
Remove LIBS variable in Makefile
Disable compilation unit tests as they're not used
Remove bundles Python libraries and use ones provided by ports
Remove update and social media buttons in WebUI
Remove sign-in notification in WebUI

Sources:
https://git.progress-linux.org/distributions/engywuck-backports/packages/netdata/tree/debian/patches/debian/0001-use-system-python.patch
https://git.progress-linux.org/distributions/engywuck-backports/packages/netdata/tree/debian/patches/debian/0008-remove-update-button.patch
https://git.progress-linux.org/distributions/engywuck-backports/packages/netdata/tree/debian/patches/debian/0009-remove-social-media-buttons.patch
https://git.progress-linux.org/distributions/engywuck-backports/packages/netdata/tree/debian/patches/debian/0012-remove-signin.patch

Run-time tested on: FreeBSD 13.0-CURRENT #0 r358620 (AMD64)
Compile tested on: 12.1-RELEASE using Poudriere
Comment 4 Matthias Andree freebsd_committer freebsd_triage 2020-04-01 08:52:37 UTC 
maintainer timeout
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-04-01 09:00:14 UTC 
A commit references this bug:

Author: mandree
Date: Wed Apr  1 08:59:15 UTC 2020
New revision: 530206
URL: https://svnweb.freebsd.org/changeset/ports/530206

Log:
  net/mgmt/netdata: Update to 1.20.0

  PR:		244323
  Submitted by:	Dries Michiels <driesm.michiels@gmail.com>
  Approved by:	maintainer timeout (mmohki@, 38 d)

Changes:
  head/net-mgmt/netdata/Makefile
  head/net-mgmt/netdata/distinfo
  head/net-mgmt/netdata/files/patch-collectors_python.d.plugin_Makefile.am
  head/net-mgmt/netdata/files/patch-collectors_python.d.plugin_python__modules_bases_loaders.py
  head/net-mgmt/netdata/files/patch-web_gui_index.html
  head/net-mgmt/netdata/pkg-plist