Bug 244355

Summary: textproc/ripgrep: don't install completion file for fish
Product: Ports & Packages Reporter: Alan Somers <asomers>
Component: Individual Port(s)Assignee: Mateusz Piotrowski <0mp>
Status: Closed FIXED    
Severity: Affects Many People CC: 0mp, petteri.valkonen
Priority: --- Flags: petteri.valkonen: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Don't install rg.fish none

Description Alan Somers freebsd_committer freebsd_triage 2020-02-24 00:40:34 UTC
Created attachment 211877 [details]
Don't install rg.fish

ripgrep tries to install a completion file for the fish shell.  But the next version of shells/fish includes that file, creating a conflict.  The best way to resolve the conflict is to let fish manage the file itself.
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-02-24 13:03:06 UTC
A commit references this bug:

Author: 0mp
Date: Mon Feb 24 13:02:10 UTC 2020
New revision: 526967
URL: https://svnweb.freebsd.org/changeset/ports/526967

Log:
  Don't install completion file for fish

  ripgrep tries to install a completion file for the fish shell.
  But the next version of shells/fish includes that file, creating
  a conflict.  The best way to resolve the conflict is to let fish
  manage the file itself.

  PR:		244355
  Submitted by:	asomers
  Approved by:	Petteri Valkonen (maintainer)

Changes:
  head/textproc/ripgrep/Makefile
Comment 2 Mateusz Piotrowski freebsd_committer freebsd_triage 2020-02-24 13:34:20 UTC
Committed! Thanks!