Bug 24437

Summary: syscons - MOUSE_MOUSECHAR fix
Product: Base System Reporter: cejkar <cejkar>
Component: kernAssignee: yokota <yokota>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 5.0-CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff
none
file.diff none

Description cejkar 2001-01-18 19:20:02 UTC 
	When changing MOUSE_MOUSECHAR over vidcontrol, original characters
	are not restored correcty. Instead, characters 0, 1, 2, and 3
	are loaded in their position: Patch #1, lower change.

	Right values for MOUSE_MOUSECHAR (c) are 0 <= c <= UCHAR_MAX - 3,
	but kernel allows only 0 <= c <= UCHAR_MAX - 5 and vidcontrol
	allows 0 <= c <= UCHAR_MAX. Kernel fix: Patch #1, upper change.
	Vidcontrol fix: Patch #2.

Fix: $FreeBSD: src/sys/dev/syscons/scmouse.c,v 1.16 2000/10/09 08:08:28 phk Exp $

"$FreeBSD: src/usr.sbin/vidcontrol/vidcontrol.c,v 1.33 2000/10/08 21:34:00 phk Exp $";
Comment 1 Johan Karlsson freebsd_committer freebsd_triage 2001-01-22 21:13:26 UTC 
Responsible Changed
From-To: freebsd-bugs->yokota

Over to sc maintainer.
Comment 2 Peter Pentchev 2001-01-29 09:26:49 UTC 
On Thu, Jan 18, 2001 at 08:14:16PM +0100, cejkar@dcse.fee.vutbr.cz wrote:
> 
> >Number:         24437
> >Category:       kern
> >Synopsis:       syscons - MOUSE_MOUSECHAR fix
> >Originator:     Rudolf Cejka
> >Release:        FreeBSD 5.0-CURRENT i386
> >Organization:
> Brno University of Technology, FEE&CS, Czech Republic
> >Environment:
> 
> 	All systems with MOUSE_MOUSECHAR ioctl.
> 
> >Description:
> 
> 	When changing MOUSE_MOUSECHAR over vidcontrol, original characters
> 	are not restored correcty. Instead, characters 0, 1, 2, and 3
> 	are loaded in their position: Patch #1, lower change.
> 
> 	Right values for MOUSE_MOUSECHAR (c) are 0 <= c <= UCHAR_MAX - 3,
> 	but kernel allows only 0 <= c <= UCHAR_MAX - 5 and vidcontrol
> 	allows 0 <= c <= UCHAR_MAX. Kernel fix: Patch #1, upper change.
> 	Vidcontrol fix: Patch #2.

FWIW, It Works For Me (tm) - been running with this patch for a couple
of days, and yes, it did get rid of the pesky \002-\005 chars popping
up every now and then.

G'luck,
Peter

-- 
Do you think anybody has ever had *precisely this thought* before?
Comment 3 Andrey A. Chernov freebsd_committer freebsd_triage 2001-04-21 15:12:46 UTC 
State Changed
From-To: open->analyzed

Fix commited into -current
Comment 4 yokota freebsd_committer freebsd_triage 2001-07-20 16:14:55 UTC 
State Changed
From-To: analyzed->closed

Fixed by ache.