Summary: | mail/postfix-policyd-spf-python: Update to 2.9.2 and rename | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Yasuhiro Kimura <yasu> | ||||||||||||||
Component: | Individual Port(s) | Assignee: | Danilo G. Baio <dbaio> | ||||||||||||||
Status: | Closed FIXED | ||||||||||||||||
Severity: | Affects Some People | CC: | dbaio, yasu | ||||||||||||||
Priority: | --- | Keywords: | needs-qa | ||||||||||||||
Version: | Latest | Flags: | dbaio:
maintainer-feedback+
|
||||||||||||||
Hardware: | Any | ||||||||||||||||
OS: | Any | ||||||||||||||||
Attachments: |
|
Thank you for the report and patch. Please rename to py-spf-engine [1] per python naming policy [2]. Question: Should the rc script name and variables be renamed to match the port too? [1] https://pypi.org/project/spf-engine/ [2] https://wiki.freebsd.org/Python/PortsPolicy#Naming Created attachment 211961 [details] Updated patch file (In reply to Kubilay Kocak from comment #1) Updated. Created attachment 213945 [details]
Updated patch file
Update patch to make it fit to latest ports tree.
Created attachment 214475 [details]
Updated patch file
Update patch to make it fit to latest ports tree.
Created attachment 215058 [details]
Updated patch file
Update patch to make it fit to latest ports tree.
This change will directly affect all users. My suggestion: - Add mail/py-spf-engine as a new port (repocopy). - Deprecate mail/postfix-policyd-spf-python and set an expiry date (3 months?) bump PORTREVISION Configure conflicts if necessary This way users will be warned and they will change their configs and packages when they have time for it. Created attachment 215074 [details] Updated patch file (In reply to Danilo G. Baio from comment #6) Thank you for feedback. I updated patch according to your recommendation. To apply attached patch, please take following steps. 1. cd /usr/ports 2. svn copy mail/postfix-policyd-spf-python mail/py-spf-engine 3. svn patch /path/to/attached/patch A commit references this bug: Author: dbaio Date: Sun May 31 13:49:31 UTC 2020 New revision: 537162 URL: https://svnweb.freebsd.org/changeset/ports/537162 Log: Add mail/py-spf-engine, Deprecate mail/postfix-policyd-spf-python Give time to users to change their env The new port is the successor, it supports milter feature and its config file is in another path. PR: 244424 Submitted by: Yasuhiro KIMURA <yasu@utahime.org> (maintainer) Changes: head/GIDs head/UIDs head/UPDATING head/mail/Makefile head/mail/postfix-policyd-spf-python/Makefile head/mail/py-spf-engine/ head/mail/py-spf-engine/Makefile head/mail/py-spf-engine/distinfo head/mail/py-spf-engine/files/patch-setup.py head/mail/py-spf-engine/files/patch-spf__engine_milter__spf.py head/mail/py-spf-engine/files/pkg-message.in head/mail/py-spf-engine/files/pyspf-milter.in head/mail/py-spf-engine/pkg-descr Committed, thanks! |
Created attachment 211945 [details] Patch file * Update to 2.9.2. * Rename this port to mail/spf-engine because the project is superseded by its successor. To apply attached patch, please take following steps. 1. cd /usr/ports 2. svn move mail/postfix-policyd-spf-python mail/spf-engine 3. svn patch /path/to/attached/patch