Summary: | dma(8): Refresh from upstream | ||||||
---|---|---|---|---|---|---|---|
Product: | Base System | Reporter: | Jan-Piet Mens <ports> | ||||
Component: | bin | Assignee: | freebsd-bugs (Nobody) <bugs> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Some People | CC: | bapt, emaste, freebsd, freebsd, garga, pi | ||||
Priority: | --- | Keywords: | needs-qa, patch | ||||
Version: | 12.1-RELEASE | Flags: | koobs:
mfc-stable12?
|
||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 256608 | ||||||
Attachments: |
|
Description
Jan-Piet Mens
2020-03-06 11:31:49 UTC
@Jan-Piet Could you attach the proposed patch as an attachment please Created attachment 212184 [details]
patch to import dma
(In reply to Kubilay Kocak from comment #1) Kubilay, I have now prepared a patch which I herewith attach. It compiles on my test system and the binary appears to do what I think it should. :-) Two notes: 1) We (at $dayjob) found an issue with handling of newaliases that's only fixed in HEAD for DMA. (Effectively, newaliases is broken if called with full path). 2) There's a newaliases bug that causes alias files to not be read if an alternate one is defined. (https://github.com/corecode/dma/issues/90) FreeBSD devs may want to locally patch these, or wait for another release. (In reply to Dan Mahoney from comment #4) What is the purpose of running DMA newaliases? The only thing it will do is validate the syntax of /etc/mail/aliases. The mailer.conf for DMA (libexec/dma/dmagent/mailer.conf - installed as /etc/mail/mailer.conf if WITHOUT_SENDMAIL=yes) doesn't even include a translation for newaliases. (Admittedly however mailer.conf(5) does.) (In reply to Helge Oldach from comment #5) I mentioned this on the ports mailing list. Many deploy tools like puppet will call "newaliases" (bareword, no args) when they touch aliases. We don't want to break this behavior. An alias should be an alias regardless of the installed system mta. -Dan updated in head |