Bug 244753
| Summary: | lang/rexx-regutil: fix build problem with _WANT_SEMUN | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Bob Eager <bob> | ||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||
| Status: | Closed Not A Bug | ||||||
| Severity: | Affects Some People | Keywords: | buildisok | ||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/125658940 -D_WANT_SEMUN was added in r463452, why is this change needed? The Makefile in the distribution (Makefile.bsd) doesn't honour CFLAGS - it seems to be one of a set of portable Makefiles that use their own rules. The patch adds -D_WANT_SEMUN to the port's Makefile.bsd. Without this, the build can fail. Tested on 12.2-RELEASE-p4 and the ports tree pulled today. (In reply to bob from comment #3) The flag is correctly passed to the build: ===> Building for rexx-regutil-1.26_2 cc -O2 -pipe -D_WANT_SEMUN -fstack-protector-strong -fno-strict-aliasing -g -fpic -pipe -D_SEMUN_DEFINED -DUSE_STATFS -DINCL_MOUNT -DHAS_F_MNTFROMNAME -DMMAP -DUSE_TERMCAP_DB -DHAS_GETBOOTFILE -DHAS_WCHAR -I /usr/local/include -c regfilesys.c -o regfilesys.o cc -O2 -pipe -D_WANT_SEMUN -fstack-protector-strong -fno-strict-aliasing -g -fpic -pipe -D_SEMUN_DEFINED -DUSE_STATFS -DINCL_MOUNT -DHAS_F_MNTFROMNAME -DMMAP -DUSE_TERMCAP_DB -DHAS_GETBOOTFILE -DHAS_WCHAR -I /usr/local/include -c regini.c -o regini.o cc -O2 -pipe -D_WANT_SEMUN -fstack-protector-strong -fno-strict-aliasing -g -fpic -pipe -D_SEMUN_DEFINED -DUSE_STATFS -DINCL_MOUNT -DHAS_F_MNTFROMNAME -DMMAP -DUSE_TERMCAP_DB -DHAS_GETBOOTFILE -DHAS_WCHAR -I /usr/local/include -c regmacrospace.c -o regmacrospace.o ... It builds fine on all supported FreeBSD versions. I don't see why this change is needed. OK, it was submitted a year ago so it may be fixed. Feel free to close this PR. If I encounter the problem again here I will patch locally until someone else complains! |
Created attachment 212347 [details] Patches for Makefiles The addition of _WANT_SEMUN in base has affected some builds of this port. The attached patch bumps the PORTREVISION and explicitly sets _WANT_SEMUN in the port Makefile.