Bug 244808

Summary: databases/rrdtool: "VRULE:0" may cause segmentation fault
Product: Ports & Packages Reporter: John W. O'Brien <john>
Component: Individual Port(s)Assignee: Niclas Zeising <zeising>
Status: Closed FIXED    
Severity: Affects Only Me CC: john
Priority: --- Keywords: buildisok
Version: LatestFlags: bugzilla: maintainer-feedback? (zeising)
Hardware: Any   
OS: Any   
URL: https://github.com/oetiker/rrdtool-1.x/issues/1078
Attachments:
Description Flags
databases/rrdtool: Backport fix for upstream bug #1078 none

Description John W. O'Brien 2020-03-14 17:55:20 UTC 
Created attachment 212408 [details]
databases/rrdtool: Backport fix for upstream bug #1078

When rrdgraph(1) is invoked with a vertical rule graph element at time 0 ("VRULE:0"), the process may terminate with a segmentation fault due to an array read bounds violation. This can occur, for example, when sysutils/munin-master generates a graph from a plugin that produces no values.

This has been fixed upstream. The attached patch backports the upstream fix.
Comment 1 Automation User 2020-03-29 03:41:52 UTC 
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/130686773
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-04-01 15:32:41 UTC 
A commit references this bug:

Author: zeising
Date: Wed Apr  1 15:32:14 UTC 2020
New revision: 530222
URL: https://svnweb.freebsd.org/changeset/ports/530222

Log:
  databases/rrdtool: fix segmentation fault

  Fix a segmentation fault in rrd_graph:print_calc when vidx is -1 on GF_VRULE
  Pull in upstream patch to fix the issue.
  This fixes upstream bug #1078

  PR:		244808
  Submitted by:	John W. O'Brien

Changes:
  head/databases/rrdtool/Makefile
  head/databases/rrdtool/files/patch-src_rrd__graph__helper.c
Comment 3 Niclas Zeising freebsd_committer freebsd_triage 2020-04-01 15:33:13 UTC 
COmmitted, thanks, and sorry for the delay.
Comment 4 John W. O'Brien 2020-04-01 15:56:38 UTC 
(In reply to Niclas Zeising from comment #3)

No worries. Thanks for the commit!