Bug 244812
| Summary: | security/krb5-appl: remove invalid configure arg, unneeded BROKEN | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | John Hein <jcfyecrayz> | ||||
| Component: | Individual Port(s) | Assignee: | Cy Schubert <cy> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | cy | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(cy) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
fixed. A commit references this bug: Author: cy Date: Tue Mar 17 01:43:10 UTC 2020 New revision: 528552 URL: https://svnweb.freebsd.org/changeset/ports/528552 Log: Simplify configuration. PR: 244812 Submitted by: John Hein <jcfyecrayz at liamekaens.com> (with modification) Changes: head/security/krb5-appl/Makefile --enable-shared is still there. There was no need to remove it. (In reply to Cy Schubert from comment #4) I'm not sure I understand your thinking here. As far as I can tell, --enabled-shared is not a valid configure option and has not been since krb5-appl 1.0. So, yes, since configure only warns about unsupported options (see original description), it needn't be removed, but then --enable-furbleblatz would be fine, too. Thanks for making the other changes, by the way. Apologies. I assumed it still was. It will be gone in my next push. A commit references this bug: Author: cy Date: Thu Mar 19 12:32:39 UTC 2020 New revision: 528722 URL: https://svnweb.freebsd.org/changeset/ports/528722 Log: --enable-shared is no longer configure option. PR: 244812 Reported by: John Hein <jcfyecrayz at liamekaens.com> Changes: head/security/krb5-appl/Makefile (In reply to commit-hook from comment #7) Thanks. |
Created attachment 212412 [details] [patch] fix/simplify CONFIGURE_ARGS; remove invalid(?) BROKEN section Attached is a patch to polish up security/krb5-appl a bit: - update configure args: o --with-krb5 doesn't need the full path to krb5-config o --enable-shared should have gone away with krb5-appl-1.0 configure: WARNING: unrecognized options: --enable-shared - unneeded BROKEN? o I removed the BROKEN section and tested with various combinations of default & non-default LOCALBASE & PREFIX. All built just fine. It was not clear what the original breakage was, but I did not detect any problems in the current ports tree. Patch was QA tested with poudriere testport, 11/stable/amd64.