Summary: | editors/libreoffice fails to build on 13-CURRENT | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | Cy Schubert <cy> |
Component: | Individual Port(s) | Assignee: | FreeBSD Office Team <office> |
Status: | Closed FIXED | ||
Severity: | Affects Only Me | CC: | Trond.Endrestol, emaste, lwhsu |
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(office) |
Version: | Latest | ||
Hardware: | Any | ||
OS: | Any | ||
Bug Depends on: | |||
Bug Blocks: | 244251 | ||
Attachments: |
Description
Cy Schubert
2020-03-16 19:09:43 UTC
I think the declarations and definitions of the overloaded operators lack const before the open curly bracket. (In reply to Trond.Endrestol from comment #1) Thanks for the analysis, do you think it is possible to have a patch for this? Created attachment 212463 [details]
Patch for vcl/inc/unx/saltype.h
It's just a hunch. I will try the patch myself as soon the current build queue is done on my laptop.
(In reply to Trond.Endrestol from comment #3) I've started a build of editors/libreoffice on base/head r359017, using ports-mgmt/synth. It's not done yet, but I'm well past compiling the problematic vcl/unx/generic/gdi/salgdi.cxx. (In reply to Trond.Endrestol from comment #4) vcl/unx/generic/window/salframe.cxx passed with flying colours. (In reply to Trond.Endrestol from comment #5) Thanks, upstream also has the same patch: https://github.com/LibreOffice/core/commit/437dc68285dab0f08a1ded2193d86d64f560cd9b Please let me know if this is sufficient to fix all the compilation issues. Created attachment 212467 [details] Patch for sd/source/ui/framework/factories/BasicPaneFactory.cxx From https://github.com/LibreOffice/core/commit/0c3e90d95c2c952265625bcff590599627114ec1 and not a work of my own. Created attachment 212469 [details] Patch for sd/inc/OutlinerIterator.hxx From https://github.com/LibreOffice/core/commit/41147e20029c80c4941ca81bc5dca3782bef5d94?diff=unified Created attachment 212470 [details] Patch for sd/source/ui/view/OutlinerIterator.cxx From https://github.com/LibreOffice/core/commit/41147e20029c80c4941ca81bc5dca3782bef5d94?diff=unified Created attachment 212473 [details] Patch for compilerplugins/clang/simplifybool.cxx From https://github.com/LibreOffice/core/commit/54f292d1d199dae36257a1ceb0ff30f32a7e0824 I didn't bother about the documentation changes to compilerplugins/clang/test/simplifybool.cxx. Created attachment 212474 [details] Patch for cui/source/tabpages/tpline.cxx From https://github.com/LibreOffice/core/commit/54f292d1d199dae36257a1ceb0ff30f32a7e0824 Created attachment 212479 [details]
Patch for sc/source/ui/view/viewfunc.cxx
Inspired by the if-expression a few lines above. Maybe this patch is wrong, but the compiler stopped complaning.
Created attachment 212481 [details] Patch for sc/source/core/opencl/formulagroupcl.cxx An adaptation of https://github.com/LibreOffice/core/commit/7db6a64e40f172894e08ecec483f214f7f1d7e10#diff-e5629822afa8a035c2838f1c8d1eff77 (In reply to Trond.Endrestol from comment #13) That makes eight patches. The build succeeded. I installed the package, and LibreOffice seem to be functional. I opened a document and a spreadsheet, and I did some editing. No crash. Someone, please verify my claims. (In reply to Trond.Endrestol from comment #14) Thanks, I'm testing them. A commit references this bug: Author: lwhsu Date: Wed Mar 18 18:35:00 UTC 2020 New revision: 528660 URL: https://svnweb.freebsd.org/changeset/ports/528660 Log: Fix build with clang10 PR: 244850 Reported by: cy Submitted by: Trond.Endrestol@ximalas.info Obtained from: https://github.com/LibreOffice/core (partially) Changes: head/editors/libreoffice/Makefile head/editors/libreoffice/files/patch-clang10 |