Bug 244904

Summary: dns/nsd: 4.3.0 does not start
Product: Ports & Packages Reporter: Hajimu UMEMOTO <ume>
Component: Individual Port(s)Assignee: Kurt Jaeger <pi>
Status: Closed FIXED    
Severity: Affects Many People CC: frederik-mueller, jaap, morgan, pi
Priority: --- Keywords: needs-qa
Version: LatestFlags: jaap: maintainer-feedback+
koobs: merge-quarterly-
Hardware: Any   
OS: Any   
Attachments:
Description Flags
dns/nsd/files/patch-server.c none

Description Hajimu UMEMOTO freebsd_committer freebsd_triage 2020-03-19 09:26:49 UTC
Created attachment 212521 [details]
dns/nsd/files/patch-server.c

nsd 4.3.0 fails to start with following error:

    [2020-03-19 10:56:03.988] nsd[6411]: error: setsockopt(..., SO_SETFIB, 0, ...) failed: Bad address

The attached patch should fix this problem.
Comment 1 Jaap Akkerhuis 2020-03-19 10:44:18 UTC
(In reply to Hajimu UMEMOTO from comment #0)

Wonder why I missed this. Agree with fix is the fix. Also approved by upstream.

The PORTREVISION=1 should be set in the Makefile as well.
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2020-03-19 11:31:29 UTC
The 4.3.0 update is not in quarterly, so no quarterly necessary.
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-03-19 11:31:39 UTC
A commit references this bug:

Author: pi
Date: Thu Mar 19 11:30:49 UTC 2020
New revision: 528710
URL: https://svnweb.freebsd.org/changeset/ports/528710

Log:
  dns/nsd: fix startup

  - see also: https://github.com/NLnetLabs/nsd/issues/78

  PR:		244904
  Submitted by:	ume
  Approved by:	Jaap Akkerhuis <jaap@NLnetLabs.nl> (maintainer)

Changes:
  head/dns/nsd/Makefile
  head/dns/nsd/files/patch-server.c
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2020-03-19 11:39:36 UTC
Also: rej
Comment 5 Frederik Müller 2020-03-25 19:36:27 UTC
stating from the logfile nsd is starting after applying the patch via ports collection.

But apparently the init-script is not finishing, so the machine hangs on boot if nsd_enable="YES" commented in in /etc/rc.conf.

The nsd-log (even with debug-mode set to yes) doesn't show any errors. Do you happen to have a hint to debug this?

If this is the wrong place to ask, please direct me to the right place :)

nsd-4.3.0_1
FreeBSD 11.3-RELEASE-p7
Comment 6 Frederik Müller 2020-03-25 20:37:19 UTC
(In reply to Frederik Müller from comment #5)

Nevermind, for some reason it worked now.