Bug 244947
| Summary: | java/openjdk12: Fails to build on on 13.0-CURRENT | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Trond Endrestøl <Trond.Endrestol> |
| Component: | Individual Port(s) | Assignee: | freebsd-java (Nobody) <java> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | glewis, koobs |
| Priority: | --- | Keywords: | needs-patch |
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(java) |
| Hardware: | Any | ||
| OS: | Any | ||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244803 | ||
| Attachments: | |||
|
Description
Trond Endrestøl
2020-03-21 11:20:44 UTC
Created attachment 212572 [details]
Patch for src/hotspot/share/runtime/arguments.cpp
Patch 1 of 5. Turned pointer comparison into regular C-style string comparison.
Created attachment 212573 [details]
Patch for src/hotspot/share/c1/c1_LIR.cpp
Patch 2 of 5. Weird indentation makes Clang 10 highly suspicious. Solved by adding curly braces.
Created attachment 212574 [details]
Patch for src/hotspot/share/runtime/sharedRuntime.cpp
Patch 3 of 5. Clang 10 wants the extra parenthesis.
Created attachment 212575 [details]
Patch for src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.hpp
Patch 4 of 5. Weird indentation makes Clang 10 highly suspicious. Solved by adding curly braces.
Created attachment 212576 [details]
Patch for src/java.base/share/native/libfdlibm/e_asin.c
Patch 5 of 5. Added curly braces to the else branch.
@Trond Can you produce a single patch against the port, fixing the errors you've identified using `make makepatch` [1] please: [1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/slow-patch.html Created attachment 212819 [details]
Patch for Clang 10
I think the patch for e_asin.c is incorrect Compare your patch with https://svnweb.freebsd.org/base/head/lib/msun/src/e_asin.c?revision=317349&view=markup#l87 Nope my bad. They will do the same thing as the FreeBSD version due to the return in the if statement. A commit references this bug: Author: glewis Date: Sat Apr 18 20:42:12 UTC 2020 New revision: 532044 URL: https://svnweb.freebsd.org/changeset/ports/532044 Log: Update to 12.0.2+10.4 PR: 244947 Submitted by: Trond.Endrestol@ximalas.info Changes: head/java/openjdk12/Makefile head/java/openjdk12/distinfo head/java/openjdk12/files/patch-src_hotspot_os__cpu_bsd__aarch64_vm__version__bsd__aarch64.cpp Pulled upstream, released and integrated. |
