Bug 24503

Summary: /stand/sysinstall fdisk/label can't access over 20 drives
Product: Base System Reporter: mikeh <mikeh>
Component: confAssignee: Jens Schweikhardt <schweikh>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.2-STABLE   
Hardware: Any   
OS: Any   

Description mikeh 2001-01-21 10:20:00 UTC
- Even with all proper /dev entries present, sysinstall displays only the
  first 20 devices, rendering it impossible to access da20+.

    lqqqqqqqqqqqqqqqqqqqqqqqqqq Select Drive(s) qqqqqqqqqqqqqqqqqqqqqqqqqqk
    x Please select the drive, or drives, on which you wish to perform    x
    x this operation.  If you are attempting to install a boot partition  x
    x on a drive other than the first one or have multiple operating      x
    x systems on your machine, you will have the option to install a boot x
    x manager later.  To select a drive, use the arrow keys to move to it x
    x and press [SPACE].  To de-select it, press [SPACE] again.           x
    x                                                                     x
    x Select OK or Cancel to leave this menu.                             x
    x lqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqk x
    x x                         [ ] da0   da0                           x x
    x x                         [ ] da1   da1                           x x
    x x                         [ ] da2   da2                           x x
    x x                         [ ] da3   da3                           x x
    x x                         [ ] da4   da4                           x x
    x x                         [ ] da5   da5                           x x
    x x                         [ ] da6   da6                           x x
    x x                         [ ] da7   da7                           x x
    x x                         [ ] da8   da8                           x x
    x x                         [ ] da9   da9                           x x
    x x                         [ ] da10  da10                          x x
    x x                         [ ] da11  da11                          x x
    x x                         [ ] da12  da12                          x x
    x x                         [ ] da13  da13                          x x
    x x                         [ ] da14  da14                          x x
    x x                         [ ] da15  da15                          x x
    x x                         [ ] da16  da16                          x x
    x x                         [ ] da17  da17                          x x
    x x                         [ ] da18  da18                          x x
    x x                         [ ] da19  da19                          x x
    x mqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqj x
    tqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqu
    x                       [  OK  ]       Cancel                         x
    mqqq[ Press F1 for important information regarding disk geometry! ]qqqj

- Reproduced on another (4.2-STABLE) machine with even more disks (30);
  it listed only ad0 and da0-da18.

How-To-Repeat: 
- On a computer with more than 20 harddrives, run /stand/sysinstall.
- Go do post-install Configuration, then Fdisk or Label
- Attempt to access the 21st device.
Comment 1 Jens Schweikhardt freebsd_committer freebsd_triage 2001-05-06 15:45:36 UTC
State Changed
From-To: open->analyzed

It appears the culprit is in /usr/src/lib/libdisk/libdisk.h, 
#define MAX_NO_DISKS 20 
I'll see if we can bump this number to 32 without breaking anything. 


Comment 2 Jens Schweikhardt freebsd_committer freebsd_triage 2001-05-06 15:45:36 UTC
Responsible Changed
From-To: freebsd-bugs->schweikh

I'm working on libdisk anyway.
Comment 3 Jens Schweikhardt freebsd_committer freebsd_triage 2001-05-14 21:53:42 UTC
State Changed
From-To: analyzed->closed

Bumped max no of disks to 32 in libdisk. Another magic number, hmm. 
Would anyone consider it silly to bump this number even further to 
max-no-of-scsi controllers * max-channels-per controller * 15 disks 
per channel? Does anyone know of systems with > 32 disks?