Bug 245058

Summary: net/concourse-fly: fix build on aarch64
Product: Ports & Packages Reporter: Mikael Urankar <mikael>
Component: Individual Port(s)Assignee: Jean-Sébastien Pédron <dumbbell>
Status: Closed FIXED    
Severity: Affects Only Me Flags: dumbbell: maintainer-feedback+
Priority: ---    
Version: Latest   
Hardware: arm64   
OS: Any   
Bug Depends on:    
Bug Blocks: 242312    
Attachments:
Description Flags
patch none

Description Mikael Urankar freebsd_committer 2020-03-25 17:06:35 UTC
Created attachment 212704 [details]
patch
Comment 1 Jean-Sébastien Pédron freebsd_committer 2020-03-25 21:02:57 UTC
Hi!

I tested the patch successfully on i386.

The patch looks good to me :) Thanks!

Would you like me to commit it? Otherwise, feel free to push it.
Comment 2 Mikael Urankar freebsd_committer 2020-03-26 11:24:33 UTC
merci!
Comment 3 commit-hook freebsd_committer 2020-03-26 11:25:30 UTC
A commit references this bug:

Author: mikael
Date: Thu Mar 26 11:24:24 UTC 2020
New revision: 529175
URL: https://svnweb.freebsd.org/changeset/ports/529175

Log:
  net/concourse-fly: unbreak on aarch64

    # github.com/creack/pty
    vendor/github.com/creack/pty/pty_freebsd.go:50:20: undefined: fiodgnameArg
    vendor/github.com/creack/pty/pty_freebsd.go:63:12: undefined: _C_SPECNAMELEN
    vendor/github.com/creack/pty/pty_freebsd.go:66:9: undefined: fiodgnameArg

  Add the missing ztypes_freebsd_arm64.go file for aarch64

    # golang.org/x/sys/unix
    vendor/golang.org/x/sys/unix/ztypes_freebsd_arm64.go:400:12: undefined: uint128

  Import upstream patch https://github.com/golang/sys/commit/33540a1f603772f9d4b761f416f5c10dade23e96

  PR:		245058
  Approved by:	dumbbell (maintainer), manu (mentor, implicit)

Changes:
  head/net/concourse-fly/files/
  head/net/concourse-fly/files/patch-vendor_github.com_creack_pty_ztypes__freebsd__arm64.go
  head/net/concourse-fly/files/patch-vendor_golang.org_x_sys_unix_ztypes__freebsd__arm64.go