Bug 245088

Summary: deskutils/ausweisapp2: Fixed build with required version OpenSSL for FreeBSD 11.3
Product: Ports & Packages Reporter: Martin Filla <freebsd>
Component: Individual Port(s)Assignee: Tobias Kortkamp <tobik>
Status: Closed FIXED    
Severity: Affects Many People CC: 0mp, freebsd
Priority: --- Flags: freebsd: maintainer-feedback+
tobik: merge-quarterly+
Version: Latest   
Hardware: Any   
OS: Any   
URL: http://beefy9.nyi.freebsd.org/data/113amd64-default/529158/logs/ausweisapp2-1.20.0_1.log
Attachments:
Description Flags
ausweisapp2.patch
none
ausweisapp2.patch
none
ausweisapp2.patch
none
ausweisapp2.diff freebsd: maintainer-approval+

Description Martin Filla 2020-03-27 00:12:07 UTC
Created attachment 212741 [details]
ausweisapp2.patch

Hi, 
this is patch for build for FreeBSD 11.3
I added required version openssl>=1.1 .

CMake Error at /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:146 (message):
  Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
  system variable OPENSSL_ROOT_DIR: Found unsuitable version "1.0.2s", but
  required is at least "1.1" (found /usr/lib/libcrypto.so)
Call Stack (most recent call first):

Thank you M.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-03-27 11:59:54 UTC
This should probably use USES=ssl and its relevant variables [1] and the change needs relevant QA (poudriere) confirmation (for all values of 'ssl')

If quarterly version of this port is also affected, please set merge-quarterly flag to "?"

^Triage: This port exists in the tree, not a new port.

[1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/uses-ssl.html
Comment 2 Martin Filla 2020-03-28 00:01:07 UTC
Created attachment 212773 [details]
ausweisapp2.patch

New patch for broken openssl 11.x
Comment 3 Martin Filla 2020-03-28 11:54:19 UTC
Created attachment 212786 [details]
ausweisapp2.patch

Fixed issue with OpenSSL on FreeBSD 11.x
Comment 4 Mateusz Piotrowski freebsd_committer freebsd_triage 2020-04-09 06:59:19 UTC
The port is still not building in poudriere.

> CMake Error at /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:146 (message):
>   Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
>   system variable OPENSSL_ROOT_DIR: Found unsuitable version "1.0.2s", but
>   required is at least "1.1" (found /usr/lib/libcrypto.so)
> Call Stack (most recent call first):
>   /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:391 (_FPHSA_FAILURE_MESSAGE)
>   /usr/local/share/cmake/Modules/FindOpenSSL.cmake:447 (find_package_handle_standard_args)
>   cmake/Libraries.cmake:75 (FIND_PACKAGE)
>   CMakeLists.txt:145 (INCLUDE)
> 
> 
> -- Configuring incomplete, errors occurred!
> See also "/wrkdirs/usr/ports/deskutils/ausweisapp2/work/.build/CMakeFiles/CMakeOutput.log".
> *** Error code 1
> 
> Stop.
> make: stopped in /usr/ports/deskutils/ausweisapp2
> ===========================================================================
> [00:00:49] Error: Build failed in phase: configure
Comment 5 Martin Filla 2020-04-09 12:51:36 UTC
(In reply to Mateusz Piotrowski from comment #4)

I tested this patch in poudriere on 11.3 FreeBSD
Comment 6 Tobias Kortkamp freebsd_committer freebsd_triage 2020-04-10 08:17:18 UTC
Created attachment 213243 [details]
ausweisapp2.diff

I do not know how you tested it but the current patch does
indeed not build on 11.3.

Here's an alternative patch that is confirmed to build fine
on 11.3 and 12.1, and does not require patching any files.
As a bonus it also removes the bogus run dependencies on
qt5-buildtools and qt5-linguisttools.
Comment 7 commit-hook freebsd_committer freebsd_triage 2020-04-11 05:01:04 UTC
A commit references this bug:

Author: tobik
Date: Sat Apr 11 05:00:37 UTC 2020
New revision: 531394
URL: https://svnweb.freebsd.org/changeset/ports/531394

Log:
  deskutils/ausweisapp2: Fix build on FreeBSD 11.3

  CMake Error at /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:146 (message):
    Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
    system variable OPENSSL_ROOT_DIR: Found unsuitable version "1.0.2s", but
    required is at least "1.1" (found /usr/lib/libcrypto.so)
  Call Stack (most recent call first):
    /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:391 (_FPHSA_FAILURE_MESSAGE)
    /usr/local/share/cmake/Modules/FindOpenSSL.cmake:447 (find_package_handle_standard_args)
    cmake/Libraries.cmake:71 (FIND_PACKAGE)
    CMakeLists.txt:145 (INCLUDE)

  While here remove unnecessary qt5-buildtools and qt5-linguisttools
  run dependencies.

  PR:		245088
  Approved by:	freebsd@sysctl.cz (maintainer)

Changes:
  head/deskutils/ausweisapp2/Makefile
Comment 8 commit-hook freebsd_committer freebsd_triage 2020-04-11 05:02:06 UTC
A commit references this bug:

Author: tobik
Date: Sat Apr 11 05:01:36 UTC 2020
New revision: 531395
URL: https://svnweb.freebsd.org/changeset/ports/531395

Log:
  MFH: r531394

  deskutils/ausweisapp2: Fix build on FreeBSD 11.3

  CMake Error at /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:146 (message):
    Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
    system variable OPENSSL_ROOT_DIR: Found unsuitable version "1.0.2s", but
    required is at least "1.1" (found /usr/lib/libcrypto.so)
  Call Stack (most recent call first):
    /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:391 (_FPHSA_FAILURE_MESSAGE)
    /usr/local/share/cmake/Modules/FindOpenSSL.cmake:447 (find_package_handle_standard_args)
    cmake/Libraries.cmake:71 (FIND_PACKAGE)
    CMakeLists.txt:145 (INCLUDE)

  While here remove unnecessary qt5-buildtools and qt5-linguisttools
  run dependencies.

  PR:		245088
  Approved by:	freebsd@sysctl.cz (maintainer)

  Approved by:	ports-secteam blanket

Changes:
_U  branches/2020Q2/
  branches/2020Q2/deskutils/ausweisapp2/Makefile
Comment 9 Tobias Kortkamp freebsd_committer freebsd_triage 2020-04-11 05:02:32 UTC
Committed. Thanks.