Bug 245173
| Summary: | misc/broot: Update to 0.13.5b | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Lewis Cook <lcook> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Tobias Kortkamp <tobik> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | ||||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| URL: | https://github.com/Canop/broot/releases/tag/v0.13.5b | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 212845 [details]
broot-0.13.5.log
* Poudriere build log.
Comment on attachment 212845 [details]
broot-0.13.5.log
====> Running Q/A tests (stage-qa)
Error: /usr/local/bin/broot is linked to /usr/local/lib/libgit2.so.28 from devel/libgit2 but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libgit2.so:devel/libgit2
The release notes mention a new man page. Maybe install it too.
It would probably be best to test this with the latest lang/rust and devel/libgit2. It seems they have rerolled the release: https://github.com/Canop/broot/releases/tag/v0.13.5b (In reply to Tobias Kortkamp from comment #2) Thanks for the informative response. Addressing the warning of libgit2, it's mentioned in the crate that 'the source for libgit2 is included in the libgit2-sys crate so there's no need to pre-install the libgit2 library' [1]. Considering what you've said, granted the option between the included source or natively installed library I'm assuming the latter is preferred for rust applications? I erroneously glanced over the stage-qa message giving priority to the source included via libgit2-sys in this instance. I'll get round to building both lang/rust and devel/libgit2 in Poudriere to the latest. If there's anything else worth mentioning, I'm more than happy to make the appropriate changes. :) Cheers! [1] https://github.com/rust-lang/git2-rs#version-of-libgit2 I think the warning is pretty clear and a no-brainer to address. The stage-qa warning is not for nothing. Currently the broot package is actually broken if you do not have libgit2 installed too (and installing it is not automatic because the dependency is missing): Shared object "libgit2.so.0.99" not found, required by "broot" It is best to not overthink it when you see these kinds of stage-qa warnings and suggestions. We prefer system libraries over bundled ones and cargo.mk enforces this in a couple of cases by exporting the appropriate environment variables. Many of *-sys crates offer these kind of knobs. (In reply to Tobias Kortkamp from comment #6) Great clarification. I shall take this into account and apply where needed. Once again thanks for your time, understanding and pushing me in the right direction—currently rebuilding rust so unsure when I may get back with a patch, knowing my setup it could be a number of hours. Stay safe! Created attachment 212903 [details]
broot-0.13.5b.diff
* Remove 'DISTVERSION/PREFIX' and use 'PORTVERSION' instead for the version naming;
* Add libgit2 lib dependency via 'LIB_DEPENDS';
* Bump 'CARGO_CRATES' dependencies and update distinfo;
* Amend 'PLIST_FILES' to included manpage and include pre-build target for replacing appropriate date/version in the manpage. Account for in post-install too.
Created attachment 212904 [details]
broot-0.13.5b.diff
* Poudriere build log with latest lang/rust and devel/libgit2.
Committed without GH_TAGNAME. Thanks. A commit references this bug: Author: tobik Date: Tue Mar 31 19:13:29 UTC 2020 New revision: 530005 URL: https://svnweb.freebsd.org/changeset/ports/530005 Log: misc/broot: Update to 0.13.5b - Install new manual - Add missing libgit2 dependency Changes: https://github.com/Canop/broot/releases/tag/v0.13.5b PR: 245173 Submitted by: Lewis Cook <vulcan@wired.sh> (maintainer) Changes: head/misc/broot/Makefile head/misc/broot/distinfo |
Created attachment 212844 [details] broot-0.13.5.diff Changes: * Bump DISTVERSION to 0.13.5 and update distinfo. Testing: * No errors reported with portlint, built in Poudriere and application works as expected (logs attached).