Bug 245240
| Summary: | biology/kallisto: fix build on GCC architectures | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Piotr Kubaj <pkubaj> | ||||
| Component: | Individual Port(s) | Assignee: | Jason W. Bacon <jwb> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | jwb | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(jwb) pkubaj: merge-quarterly? |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Created attachment 212932 [details]
patch
A commit references this bug: Author: jwb Date: Wed Apr 1 23:35:39 UTC 2020 New revision: 530250 URL: https://svnweb.freebsd.org/changeset/ports/530250 Log: kallisto: Patch for build with GCC PR: ports/245240 Submitted by: pkubaj Changes: head/biology/kallisto/Makefile head/biology/kallisto/files/patch-src_Bootstrap.h This would seem to qualify for a blanket MFH approval on the condition that the port is broken in the latest branch. https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html#ports-qa-quarterly However, the guide does not indicate how to log this case. What should go under "Approved by:" in cases like this? (In reply to Jason W. Bacon from comment #3) I usually just do: Approved by: portmgr (fix build blanket) Fixed, thanks for the patch! A commit references this bug: Author: jwb Date: Thu Apr 2 13:41:03 UTC 2020 New revision: 530371 URL: https://svnweb.freebsd.org/changeset/ports/530371 Log: MFH: r530250 kallisto: Patch for build with GCC Fixes broken build on GCC-based platforms PR: ports/245240 Submitted by: pkubaj Approved by: portmgr (fix build blanket) Changes: _U branches/2020Q2/ branches/2020Q2/biology/kallisto/Makefile branches/2020Q2/biology/kallisto/files/patch-src_Bootstrap.h |
kallisto 0.46.2 fails to build with GCC: In file included from /wrkdirs/usr/ports/biology/kallisto/work/kallisto-0.46.2/src/Bootstrap.cpp:1: /wrkdirs/usr/ports/biology/kallisto/work/kallisto-0.46.2/src/Bootstrap.h:57:106: error: 'uint' has not been declared 57 | const std::vector<int>& fld, const std::vector<int>& preBias, const std::vector<double>& postBias, uint compression, size_t index_version, | ^~~~ Including sys/types.h is necessary. Please MFH after commit since new quarterly is imminent.