Bug 245281

Summary: net-im/dino 0.1.0_1 fails to build: Could NOT find SignalProtocol: Found unsuitable version
Product: Ports & Packages Reporter: p5B2EA84B3
Component: Individual Port(s)Assignee: Ashish SHUKLA <ashish>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (ashish)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Probable fix none

Description p5B2EA84B3 2020-04-02 11:37:07 UTC 
CMake Error at /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:146 (message):
  Could NOT find SignalProtocol: Found unsuitable version "2.3.3", but
  required is exact version "2.3.2" (found
  /usr/local/lib/libsignal-protocol-c.so)
Call Stack (most recent call first):
  /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:391 (_FPHSA_FAILURE_MESSAGE)
  cmake/FindSignalProtocol.cmake:9 (find_package_handle_standard_args)
  plugins/signal-protocol/CMakeLists.txt:35 (find_package)


-- Configuring incomplete, errors occurred!
See also "/wrkdirs/usr/ports/net-im/dino/work/.build/CMakeFiles/CMakeOutput.log".
See also "/wrkdirs/usr/ports/net-im/dino/work/.build/CMakeFiles/CMakeError.log".
*** Error code 1

Stop.
make: stopped in /usr/ports/net-im/dino
=>> Cleaning up wrkdir
===>  Cleaning for dino-0.1.0_1
build of net-im/dino | dino-0.1.0_1 ended at Thu Apr  2 13:18:50 CEST 2020
build time: 00:02:29
!!! build failure encountered !!!
Comment 1 Ashish SHUKLA freebsd_committer freebsd_triage 2020-04-02 18:52:19 UTC 
Created attachment 212987 [details]
Probable fix

Prepared this diff to import/build libsignal-protocol-c in tree. I'm building it on poudriere. In the meantime, if you like to try it, please go ahead, and provide me if any feedback you have.

Thanks!
Comment 2 Ashish SHUKLA freebsd_committer freebsd_triage 2020-04-02 18:53:19 UTC 
(In reply to p5B2E9A8F from comment #0)

Added a patch. If you could try it, that'll be great.

Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-04-02 19:37:56 UTC 
A commit references this bug:

Author: ashish
Date: Thu Apr  2 19:37:14 UTC 2020
New revision: 530404
URL: https://svnweb.freebsd.org/changeset/ports/530404

Log:
  - Fix brokenness with net/libsignal 2.3.3. Upstream depends on
    particular version (2.3.2), so reference its distfile, build
    it in tree.
  - Bump PORTREVISION as dependencies are changed

  PR:		245281

Changes:
  head/net-im/dino/Makefile
  head/net-im/dino/distinfo
Comment 4 Ashish SHUKLA freebsd_committer freebsd_triage 2020-04-02 19:39:35 UTC 
Seems to build/work fine.

Thanks for reporting.
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-04-08 15:52:34 UTC 
A commit references this bug:

Author: ashish
Date: Wed Apr  8 15:51:53 UTC 2020
New revision: 531121
URL: https://svnweb.freebsd.org/changeset/ports/531121

Log:
  MFH: r530404 (runtime fix)

  - Fix brokenness with net/libsignal 2.3.3. Upstream depends on
    particular version (2.3.2), so reference its distfile, build
    it in tree.
  - Bump PORTREVISION as dependencies are changed

  PR:		245281

  Approved by:	portmgr (blanket)

Changes:
_U  branches/2020Q2/
  branches/2020Q2/net-im/dino/Makefile
  branches/2020Q2/net-im/dino/distinfo