Bug 245387

Summary: graphics/libheif: Fails to build EXAMPLES option disabled
Product: Ports & Packages Reporter: Marián Černý <majo-bugs.freebsd.org>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Open ---    
Severity: Affects Some People CC: feld, fernape, freebsd, t.m.guymer, tech-lists
Priority: --- Keywords: needs-patch, needs-qa
Version: LatestFlags: bugzilla: maintainer-feedback? (freebsd)
koobs: merge-quarterly?
Hardware: Any   
OS: Any   

Description Marián Černý 2020-04-05 21:29:46 UTC
Building libheif with all config options disabled (especially Examples) fails in my system with the following error:

    --- gopath ---
    mkdir -p /src/github.com/strukturag/libheif
    mkdir: /src: Read-only file system

My root filesystem is read only and I don't wont random files to be created.

However even when I create read-write /src, I get an error:
    --- heif-test-go ---
    heif-test.go:39:2: cannot find package "github.com/strukturag/libheif/go/heif" in any of:
            /usr/local/go/src/github.com/strukturag/libheif/go/heif (from $GOROOT)
            /tmp/portbuild/usr/ports/graphics/libheif/work/go/src/github.com/strukturag/libheif/go/heif (from $GOPATH)
    *** [heif-test-go] Error code 1

(I have WRKDIRPREFIX ?= /tmp/portbuild set in /etc/make.conf.)

When I enable Examples (with make config) then the port built without an error.

Also when I change the Makefile and add:

    CONFIGURE_ARGS+=        --disable-go

then the port is build also without an error.
Comment 1 Sebastian Steinmetz 2020-06-02 08:39:42 UTC
Hi Marian,

thanks for the report. I'll have a look together with the upgrade to 1.6.2 in #246921. I agree, it should be possible to do a successful build without examples.

Best,
Sebastain
Comment 2 Thomas Guymer 2020-08-03 19:16:02 UTC
I have just come across this too. I am building with EXAMPLES=off and it fails to build with:

--- heif-test-go ---
heif-test.go:39:2: cannot find package "github.com/strukturag/libheif/go/heif" in any of:
	/usr/local/go/src/github.com/strukturag/libheif/go/heif (from $GOROOT)
	/usr/ports/graphics/libheif/work/go/src/github.com/strukturag/libheif/go/heif (from $GOPATH)
*** [heif-test-go] Error code 1

I can provide the whole build log if you want, but this seems like the most relevant bit to me.
Comment 3 tech-lists 2021-02-16 18:16:15 UTC
I'm getting this as well.

Tried downloading from the source at github and got this:

[...]

ln -sf /../go /src/github.com/strukturag/libheif/
GOPATH= PKG_CONFIG_PATH=/root/test/libheif:/root/test/libheif/libde265/dist/lib/pkgconfig/ CGO_CFLAGS="-I/root/test/libheif" CGO_LDFLAGS="-L/root/test/libheif/libheif/.libs" LD_LIBRARY_PATH=/root/test/libheif/libheif/.libs /usr/local/bin/go build -o heif-test-go heif-test.go
heif-test.go:39:2: cannot find package "github.com/strukturag/libheif/go/heif" in any of:
        /usr/local/go/src/github.com/strukturag/libheif/go/heif (from $GOROOT)
        /root/go/src/github.com/strukturag/libheif/go/heif (from $GOPATH)
*** Error code 1

[...]
Comment 4 tech-lists 2021-02-16 18:27:37 UTC
The problem I'm seeing is that the binaries are never installed. make install doesn't install anything into /usr/local/bin when installing the port. Expect to see heif-convert etc
Comment 5 tech-lists 2021-02-16 18:28:31 UTC
I should say "the problems I'm seeing with the port"
Comment 6 Mark Felder freebsd_committer 2021-03-23 22:23:43 UTC
*** Bug 253729 has been marked as a duplicate of this bug. ***