Summary: | cad/PrusaSlicer: Fix build | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | teodorsigaev <teodorsigaev> | ||||||||||
Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||||||||
Status: | Closed FIXED | ||||||||||||
Severity: | Affects Many People | CC: | fernape, teodorsigaev | ||||||||||
Priority: | --- | Keywords: | buildisok, easy, needs-qa | ||||||||||
Version: | Latest | Flags: | koobs:
merge-quarterly?
|
||||||||||
Hardware: | Any | ||||||||||||
OS: | Any | ||||||||||||
Attachments: |
|
Maintainer informed via mail Thank you for the report and patch. Could you please update your Bugzilla email address to match the MAINTAINER line in your ports, as this allows us to verify/confirm maintainer/ship easily. Thanks! Created attachment 213147 [details]
Update Makefile for correct CGAL library, maintainer email update
New version, update maintainer email
Thanks! Created attachment 213148 [details]
Update Makefile for correct CGAL library, maintainer email update
Mistype in email fix
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/133543836 Created attachment 213224 [details] additional improvements on top of submitter's patch Hi Teodor! Thanks for the patch. I updated a new version that fixes some dependencies issues. Would you mind having a look at it? Also, you might be interested in using ports-mgmt/portlint and ports-mgmt/poudriere. These tools catch most if not all of the common pitfalls we face when updating ports. You can have more information here: https://www.freebsd.org/doc/en/books/porters-handbook/book.html#testing-poudriere https://www.freebsd.org/doc/en/books/porters-handbook/book.html#porting-portlint Cheers I haven't an objection about your changes. I used portlint to check my original patch for upgrading 2.2, and got some gripes from it, fixed in original patch. I will try poudriere next time, but it will not be easy for me because, for a first glance, it uses both jail and zsh which I'm not using yet. A commit references this bug: Author: fernape Date: Fri Apr 10 09:25:43 UTC 2020 New revision: 531301 URL: https://svnweb.freebsd.org/changeset/ports/531301 Log: cad/PrusaSlicer: fix build Add devel/CGAL dependency. While here: * Change MAINTAINER email * Add missing LIB_DEPENDS * Add missing USES PR: 245418 Submitted by: teodorsigaev@gmail.com (maintainer) Changes: head/cad/PrusaSlicer/Makefile Committed, Thanks! Thank you very much! I'm very sorry but pkg-fallout@FreeBSD.org doesn't happy with USES=glu: /!\ ERRORS /!\ Unknown USES=glu *** Error code 1 Stop. make: stopped in /usr/ports/cad/PrusaSlicer Should I a report a new bug and suggest a fix? Reopen because build fail (In reply to teodorsigaev@gmail.com from comment #12) No need, I'll investigate it. Thanks! A commit references this bug: Author: fernape Date: Mon Apr 13 14:45:33 UTC 2020 New revision: 531608 URL: https://svnweb.freebsd.org/changeset/ports/531608 Log: cad/PrusaSlicer: unbreak Remove bad USES = glu and add USES_GL = glu PR: 245418 Reported by: antoine@ Changes: head/cad/PrusaSlicer/Makefile Should be fixed now. Confirm, fixed. Thank you! |
Created attachment 213146 [details] Update Makefile for correct CGAL library I've got a email from pkg-fallout about build fail of cad/PrusaSlicer. So, it's a real fail on fresh installation of FreeBSD. Suggested patch fix that. Actually, mistake make able to build package only if devel/CGAL library is already installed in system, in this case configure step runs successful. Makefile updated to work correctly, checked on fresh Amazon instance of FreeBSD.