Bug 245466
| Summary: | java/java-cup: Update to 11.b.20160615, Remove BROKEN | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jashank Jeremy <freebsd> |
| Component: | Individual Port(s) | Assignee: | Rene Ladan <rene> |
| Status: | Closed FIXED | ||
| Severity: | Affects Many People | CC: | edmondas, rene |
| Priority: | --- | Keywords: | needs-qa |
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(edmondas) koobs: merge-quarterly? |
| Hardware: | Any | ||
| OS: | Any | ||
| Attachments: | |||
Created attachment 213206 [details] ports/java/java-cup: 11.a -> 11b.20160615 (patch v2) Reroll the patch with a plist (noted while checking on bug 245447). Thank you for the patch Jeremy. Does this change just fix fetching the distfile, or does it also specifically address the BROKEN_arm* build failures as well? Hey Kubilay! This update fixes up the master site, so it's no longer unfetchable. As I've opted to cheap out and just grab a pre-built jar from upstream, the build failures should have gone away too :-) (My guess is that the build issues have gone away with intervening JVM updates --- but I don't have anything in place to test that on FreeBSD/arm.) Hi, thank you for submitted patch.
By some reason I was on able to apply it locally.
Few things that I would like to discuss:
1. Now this port just use prebuilt binary, is it good practice? Usually all ports build a software from the source code.
2. Not sure regarding LICENSE, my suggestion would be to use SMLNJ license as in lang/smlnj port.
3. I did check with portlint and changed the order of some lines.
4. CUP_VERSION placeholder in java-cup.sh.in was not replaced after installation to proper value, so maybe we don't need that variable and just use symlinked version ${JAVAJARDIR}/java-cup.jar?
See java-cup.diff for changes.
Created attachment 213282 [details]
Portlinted version, with LICENSE and fixed startup script
At 2020-04-11 12:36:27 +0000, Edmondas Girkantas wrote: > By some reason I was on able to apply it locally. Could you expand on that? > Now this port just use prebuilt binary, is it good practice? Usually all ports build a software from the source code. See bug 245447 comment 3 for more explanation. > my suggestion would be to use SMLNJ license as in lang/smlnj port. OK. > CUP_VERSION placeholder in java-cup.sh.in was not replaced after installation to proper value Whoops! I'll fix that up and reroll my patch now. Created attachment 213478 [details]
ports/java/java-cup: 11.a -> 11b.20160615 (patch v4)
A commit references this bug: Author: rene Date: Sat May 23 11:40:32 UTC 2020 New revision: 536291 URL: https://svnweb.freebsd.org/changeset/ports/536291 Log: java/java-cup: update to 11.b.20160615 and unexpire Further changes: - use a prebuilt binary instead of building from source - change license to SMLNJ in agreement with maintainer PR: 245466 Submitted by: Jashank Jeremy Approved by: maintainer MFH: 2020Q2 Changes: head/java/java-cup/Makefile head/java/java-cup/distinfo head/java/java-cup/files/ head/java/java-cup/files/java-cup.sh.in head/java/java-cup/pkg-descr A commit references this bug: Author: rene Date: Sat May 23 16:14:54 UTC 2020 New revision: 536313 URL: https://svnweb.freebsd.org/changeset/ports/536313 Log: MFH: r536291 java/java-cup: update to 11.b.20160615 and unexpire Further changes: - use a prebuilt binary instead of building from source - change license to SMLNJ in agreement with maintainer PR: 245466 Submitted by: Jashank Jeremy Approved by: maintainer Approved by: ports-secteam (joneum) Changes: _U branches/2020Q2/ branches/2020Q2/java/java-cup/Makefile branches/2020Q2/java/java-cup/distinfo branches/2020Q2/java/java-cup/files/ branches/2020Q2/java/java-cup/pkg-descr |
Created attachment 213204 [details] ports/java/java-cup: 11.a -> 11b.20160615 Hello! This port was marked broken/unfetchable, but CUP is still alive. Attached is a patch (Git-flavoured; sorry) that brings this port up-to-date.