Bug 245510
| Summary: | graphics/libepoxy: make X11 an option | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Val Packett <val> | ||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-x11 (Nobody) <x11> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | zeising | ||||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(x11) |
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 247091 | ||||||||||
| Attachments: |
|
||||||||||
This adds a ton of complexity for the benefit of not installing two headers. Can you give an argument for why you think this is needed? Thanks! (In reply to Niclas Zeising from comment #1) It's not about headers, it's making the dependency on libX11 optional. I'm trying to build a Wayland-only system with zero X11 packages. Similarly, it should be possible to build an embedded system that runs e.g. Kodi or RetroArch directly on drm and not have any X libs there either. And to use headless graphics (osmesa) on a server without any x11. Comment on attachment 213251 [details] libepoxy-opt.patch > +.include <bsd.port.options.mk> > + > +.if ${PORT_OPTIONS:MX11} > +PLIST_SUB+= X11="" > +.else > +PLIST_SUB+= X11="@comment " > +.endif > + Maybe replace with OPTIONS_SUB=yes Created attachment 213339 [details]
libepoxy-opt.patch v2
Sure
Can you move USE_GL=gl under X11 option? Otherwise, it fails to build if graphics/libglvnd is built without X11 ===> libepoxy-1.5.4 depends on shared library: libGL.so - not found Created attachment 215454 [details]
libepoxy X11 opt out v3
Does this look ok for libglvnd jbeich?
Comment on attachment 215454 [details] libepoxy X11 opt out v3 Can you move X11_MESON_TRUE X11_MESON_YES after X11_USES and X11_USE? In general, the style in options tries to follow/mimic the global one. > +#OPTIONS_DEFAULT= X11 Disabling X11 by default here but not in libglvnd/mesa-libs is pointless. A commit references this bug: Author: zeising Date: Sun Jun 14 13:56:58 UTC 2020 New revision: 538741 URL: https://svnweb.freebsd.org/changeset/ports/538741 Log: graphics/libepoxy: Make x11 support an option Make X11 support in graphics/libepoxy an option, default to on. This makes it possible to build libepoxy with only wayland support. PR: 245510 Submitted by: Greg V (with minor changes) Reviewed by: jbiech Changes: head/graphics/libepoxy/Makefile head/graphics/libepoxy/pkg-plist |
Created attachment 213251 [details] libepoxy-opt.patch This patch allows building libepoxy without X11.