Bug 245533
| Summary: | audio/faudio: workaround OSS audio crash | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jan Beich <jbeich> | ||||
| Component: | Individual Port(s) | Assignee: | Jan Beich <jbeich> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | tobik | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | Flags: | tobik:
maintainer-feedback+
jbeich: merge-quarterly- |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| URL: | https://github.com/FNA-XNA/FAudio/issues/183 | ||||||
| Attachments: |
|
||||||
Go ahead. Tests with the sndio backend fail too (without crashing though) with raw devices and without intermediary sndiod. The patch fixes that too. A commit references this bug: Author: jbeich Date: Sat Apr 11 14:15:42 UTC 2020 New revision: 531426 URL: https://svnweb.freebsd.org/changeset/ports/531426 Log: audio/faudio: work around OSS audio crash INFO: OpenAudioDevice failed: Fragment size must be a power of two PR: 245533 Approved by: tobik (maintainer) Changes: head/audio/faudio/Makefile head/audio/faudio/files/ head/audio/faudio/files/patch-src_FAudio__platform__sdl2.c Do you want this on 2020Q2 or let it bake on /latest in case of regressions? Merging it to 2020Q2 should be fine. Nevermind. 20.03 doesn't crash because https://github.com/FNA-XNA/FAudio/commit/a0f859c761bb is the culprit. Rounding up 1024 to ^2 is pointless but also harmless. |
Created attachment 213281 [details] v1 FAudio uses fragment size not compatible with OSS backend in SDL2. Upstream blames SDL2 but fixing that maybe non-trivial because OSS has many implementations: 4Front (original), DragonFly/FreeBSD (fork), Solaris (fork), Linux (ALSA wrapper), libossaudio (SunAudio wrapper).