Bug 245539

Summary: astro/wmmoonclock: update to 1.29
Product: Ports & Packages Reporter: Marco Beishuizen <mbeis>
Component: Individual Port(s)Assignee: Fernando Apesteguía <fernape>
Status: Closed FIXED    
Severity: Affects Only Me CC: fernape, mbeis
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Description Flags
astro/wmmoonclock: update to 1.29
fernape: maintainer-approval+
additional improvements on top of submitter's patch mbeis: maintainer-approval+

Description Marco Beishuizen 2020-04-11 18:09:42 UTC
Created attachment 213293 [details]
astro/wmmoonclock: update to 1.29

Update to 1.29
Comment 1 Fernando Apesteguía freebsd_committer 2020-04-15 05:39:20 UTC
Comment on attachment 213293 [details]
astro/wmmoonclock: update to 1.29

^Triage: Reporter is maintainer, set attachment maintainer-approval flag (to +) to signify maintainer approval. 

Attachment -> Details -> maintainer-approval [+], or set the flag during attach/upload step
Comment 2 Fernando Apesteguía freebsd_committer 2020-04-15 06:22:09 UTC
Created attachment 213406 [details]
additional improvements on top of submitter's patch

Hi Marco,

There are some issues with the patch:

* Add USES=pkgconfig (otherwise the port doesn't build)
* I reworked files/patch-src_wmMoonClock.c to comply with makepatch format

Would you please review this new version?

Comment 3 Marco Beishuizen 2020-04-15 10:35:03 UTC
Hmm, builds/installs/runs fine here without USES=pkgconfig but approved anyway.
Comment 4 Fernando Apesteguía freebsd_committer 2020-04-15 11:11:16 UTC
(In reply to Marco Beishuizen from comment #3)

In a clean environment or in your host? Maybe you have pkg-config already installed?
Comment 5 Marco Beishuizen 2020-04-15 12:24:44 UTC
Doing this on my own host (12.1-RELEASE-p3). Tried poudriere but that locked up after a day compiling so prefer using the live machine. And devel/pkgconf is installed, yes.
Comment 6 Fernando Apesteguía freebsd_committer 2020-04-15 12:27:27 UTC
(In reply to Marco Beishuizen from comment #5)

That's the thing then. The port finds the dependency because it happens to be installed in the host system, but in a "clean" system (like the one poudriere emulates) it will fail.

poudriere is resource hungry, but the best tool he have :-)
Comment 7 commit-hook freebsd_committer 2020-04-15 12:31:17 UTC
A commit references this bug:

Author: fernape
Date: Wed Apr 15 12:30:29 UTC 2020
New revision: 531763
URL: https://svnweb.freebsd.org/changeset/ports/531763

  astro/wmmoonclock: update to 1.29

  While here:

  * Rework patch to comply with makepatch style
  * Add missing USES=pkgconfig

  PR:     245539
  Submitted by:   mbeis@xs4all.nl (maintainer)

Comment 8 Marco Beishuizen 2020-04-15 12:56:15 UTC
Thanks for your help!
Comment 9 Fernando Apesteguía freebsd_committer 2020-04-15 13:08:28 UTC