Summary: | astro/wmmoonclock: update to 1.29 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Marco Beishuizen <mbeis> | ||||||
Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | fernape, mbeis | ||||||
Priority: | --- | ||||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Comment on attachment 213293 [details]
astro/wmmoonclock: update to 1.29
^Triage: Reporter is maintainer, set attachment maintainer-approval flag (to +) to signify maintainer approval.
Attachment -> Details -> maintainer-approval [+], or set the flag during attach/upload step
Created attachment 213406 [details]
additional improvements on top of submitter's patch
Hi Marco,
There are some issues with the patch:
* Add USES=pkgconfig (otherwise the port doesn't build)
* I reworked files/patch-src_wmMoonClock.c to comply with makepatch format
Would you please review this new version?
Thanks!
Hmm, builds/installs/runs fine here without USES=pkgconfig but approved anyway. (In reply to Marco Beishuizen from comment #3) In a clean environment or in your host? Maybe you have pkg-config already installed? Doing this on my own host (12.1-RELEASE-p3). Tried poudriere but that locked up after a day compiling so prefer using the live machine. And devel/pkgconf is installed, yes. (In reply to Marco Beishuizen from comment #5) That's the thing then. The port finds the dependency because it happens to be installed in the host system, but in a "clean" system (like the one poudriere emulates) it will fail. poudriere is resource hungry, but the best tool he have :-) A commit references this bug: Author: fernape Date: Wed Apr 15 12:30:29 UTC 2020 New revision: 531763 URL: https://svnweb.freebsd.org/changeset/ports/531763 Log: astro/wmmoonclock: update to 1.29 While here: * Rework patch to comply with makepatch style * Add missing USES=pkgconfig PR: 245539 Submitted by: mbeis@xs4all.nl (maintainer) Changes: head/astro/wmmoonclock/Makefile head/astro/wmmoonclock/distinfo head/astro/wmmoonclock/files/patch-Makefile head/astro/wmmoonclock/files/patch-src_wmMoonClock.c head/astro/wmmoonclock/files/patch-wmMoonClock.c head/astro/wmmoonclock/pkg-descr Thanks for your help! Marco Committed, Thanks! |
Created attachment 213293 [details] astro/wmmoonclock: update to 1.29 Update to 1.29