Bug 245604

Summary: x11-servers/xorg-server will link with HAL if installed
Product: Ports & Packages Reporter: Mikhail Teterin <mi>
Component: Individual Port(s)Assignee: freebsd-x11 (Nobody) <x11>
Status: Closed FIXED    
Severity: Affects Only Me CC: zeising
Priority: --- Keywords: patch
Version: LatestFlags: bugzilla: maintainer-feedback? (x11)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Explicitly disable HAL. Remove obsolete --with-shared-memory-dir flag. none

Description Mikhail Teterin freebsd_committer freebsd_triage 2020-04-13 17:28:26 UTC
Created attachment 213376 [details]
Explicitly disable HAL. Remove obsolete --with-shared-memory-dir flag.

Although HAL-support is removed from the port, the upstream code will still link with HAL (and expect it at runtime), if installed on the building machine. Depending on one's other configurations, this may prevent the Xorg from ever seeing the keyboard events, for example.

Also, the --with-shared-memory-dir is no longer a recognized configure-argument.
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-05-03 20:23:16 UTC
A commit references this bug:

Author: zeising
Date: Sun May  3 20:22:31 UTC 2020
New revision: 533807
URL: https://svnweb.freebsd.org/changeset/ports/533807

Log:
  xorg-server: Do not send spurious focus events

  Apply an upstream patch to avoid sending focus evens when grab actually does
  not change.  This fixes certain full screen applications. [1]

  Ensure that we actually don't try to find and link against HAL even if it's
  around on the system we're compiling on [2]

  Add CPE information [3]

  PR:		245854 [1] (with changes), 245604 [2], 197712 [3]
  Submitted by:	naddy@ [1], mi@ [2], arrowd [3]
  Reported by:	shun [3]
  MFH:		2020Q2

Changes:
  head/x11-servers/xorg-server/Makefile
  head/x11-servers/xorg-server/distinfo
Comment 2 Niclas Zeising freebsd_committer freebsd_triage 2020-05-03 20:31:30 UTC
Committed, thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-05-04 16:09:08 UTC
A commit references this bug:

Author: zeising
Date: Mon May  4 16:08:17 UTC 2020
New revision: 533929
URL: https://svnweb.freebsd.org/changeset/ports/533929

Log:
  MFH: r533807

  xorg-server: Do not send spurious focus events

  Apply an upstream patch to avoid sending focus evens when grab actually does
  not change.  This fixes certain full screen applications. [1]

  Ensure that we actually don't try to find and link against HAL even if it's
  around on the system we're compiling on [2]

  Add CPE information [3]

  PR:		245854 [1] (with changes), 245604 [2], 197712 [3]
  Submitted by:	naddy@ [1], mi@ [2], arrowd [3]
  Reported by:	shun [3]

  Approved by:	ports-secteam (joenum)

Changes:
_U  branches/2020Q2/
  branches/2020Q2/x11-servers/xorg-server/Makefile
  branches/2020Q2/x11-servers/xorg-server/distinfo